Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend static_variant with is_type() method #1792

Conversation

crypto-ape
Copy link
Contributor

Hey Monkeys!

This PR implements the proposal from the issue #1769 .

Ape out!

@oxarbitrage
Copy link
Member

@crypto-ape
Copy link
Contributor Author

The actual feature is implemented within the fc library, I was just about tu make a PR there.
Please, how do you await such a necessary change from a submodule to be provided other than in custom PR within that submodule?

@oxarbitrage
Copy link
Member

Need to send pull request to FC, after approved and merged a bump FC commit should be included in this one.

@crypto-ape
Copy link
Contributor Author

Okay. Here it goes.
bitshares/bitshares-fc#138

@oxarbitrage
Copy link
Member

merged bitshares/bitshares-fc#138 , please bump FC here.

for example, last merged bump is included in #1768 at commit: 90efe68

@abitmore abitmore added this to the 3.2.0 - Feature Release milestone Jun 12, 2019
@abitmore
Copy link
Member

@crypto-ape commands:

cd libraries/fc
git checkout master
git pull
cd ..
git add fc
git commit

Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you :)

@oxarbitrage oxarbitrage merged commit 99252bd into bitshares:develop Jun 14, 2019
@crypto-ape
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants