Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get_accounts isssue #1734 #1765

Merged
merged 4 commits into from
May 24, 2019
Merged

Conversation

oxarbitrage
Copy link
Member

#1734

@abitmore let me know what do you think about this before i add similar code into get_assets.

Thank you.

$ curl --silent -d '{"id":1,"method":"call","params":["database","get_accounts",[["unexisting-account-should-return-null"]]]}' http://127.0.0.1:8090/ws | jq
{
  "id": 1,
  "jsonrpc": "2.0",
  "result": [
    null
  ]
}
$

@abitmore abitmore added this to the 3.2.0 - Feature Release milestone May 19, 2019
@abitmore
Copy link
Member

abitmore commented May 19, 2019

Yes, this is what I want, although IMHO the parameter name should_throw is a bit confusing.

Please check all related APIs with a vector in parameter list. Thanks.

  • get_accounts
  • get_full_accounts
  • get_assets

@oxarbitrage oxarbitrage mentioned this pull request May 20, 2019
34 tasks
@oxarbitrage
Copy link
Member Author

Please note get_full_accounts will return empty result instead of null if the account does not exist.

get_accounts and get_assets will return null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants