Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server-rpc-endpoint to api #1726

Closed
wants to merge 1 commit into from
Closed

Conversation

xloem
Copy link
Contributor

@xloem xloem commented Apr 21, 2019

It appears to me the only way to access both the wallet api and the blockchain apis is to connect to two services simultaneously (is that correct?).

This PR adds the blockchain server information to the wallet api, so that only one endpoint need be passed to a client app that uses both.

@abitmore
Copy link
Member

IMHO this makes little sense. Having server info doesn't mean you're able to connect to the server, for example it can be behind a firewall. Actually info of cli_wallet itself is more sensitive than info of API nodes because cli_wallet may contain private keys, usually the cli_wallet should be deployed by you own, that said, you must have known info of the API node it connected already. Anyway, this is opensource software with a MIT license, you're free to modify the code locally if you need it.

@abitmore
Copy link
Member

Perhaps we can do this in the scope of #626.

@xloem
Copy link
Contributor Author

xloem commented Apr 22, 2019

thanks for the link @abitmore .. sounds like my concerns might be under discussion and this isn't the best fix for others with e.g. firewalls.

@xloem xloem closed this Apr 22, 2019
@xloem xloem mentioned this pull request Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants