Fix tests for Windows builds #1600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's clear that 3 is an issue of hardfork branch, but how about 2? Do we want to fix the next feature release, or only fix the next consensus release? |
Error 2 is a problem in the develop branch. So yes, the most appropriate place to fix that would be over there. I will take that change out of this PR and create a new one based on the develop branch. |
|
As abit correctly points out, the problem is spread across subprojects and branches. I will close this in favor of separate PRs in their respective branches/subprojects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #1593
Tests in Windows will not build due to 3 errors:
WIN32_LEAN_AND_MEANcorrects the problem, and seems to be the online consensus for fixing when this occurs.std::independent_bits_engine, and blame can be put on the c++11 spec. The work-around to the specification problem is to use unsigned integer instead of unsigned char.