Skip to content

Prevent oversized transactions #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 19, 2019
Merged

Prevent oversized transactions #1586

merged 4 commits into from
Feb 19, 2019

Conversation

jmjatlanta
Copy link
Contributor

Fixes #1573

@jmjatlanta jmjatlanta changed the title Jmj 1573 Prevent oversized transactions Feb 14, 2019
pmconrad
pmconrad suggested changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the pack_size calculation out of the single-threaded code.

@pmconrad
Copy link
Contributor

Travis reported one failure in chain_test, worked upon restart. Strange.

@jmjatlanta jmjatlanta merged commit 3846151 into hardfork Feb 19, 2019
@jmjatlanta jmjatlanta mentioned this pull request Feb 22, 2019
Closed
17 tasks
@abitmore abitmore mentioned this pull request Feb 26, 2019
Closed
17 tasks
@abitmore abitmore deleted the jmj_1573 branch February 26, 2019 12:06
@MichelSantos MichelSantos mentioned this pull request Mar 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmconrad pmconrad pmconrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0 - Protocol Upgrade Release
Development

Successfully merging this pull request may close these issues.
3 participants
@jmjatlanta @pmconrad @abitmore