Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure price_to_string works and throws as it should #1518

Merged
merged 2 commits into from
Jan 14, 2019
Merged

Make sure price_to_string works and throws as it should #1518

merged 2 commits into from
Jan 14, 2019

Conversation

jmjatlanta
Copy link
Contributor

Still gathering final requirements for ticket #1186. This PR is an improvement of the test, but incomplete until the details are sorted.

  • Finalize details

pmconrad
pmconrad approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@jmjatlanta jmjatlanta merged commit aae2b4c into develop Jan 14, 2019
@jmjatlanta jmjatlanta deleted the jmj_1186 branch January 14, 2019 15:49
@jmjatlanta jmjatlanta mentioned this pull request Jan 14, 2019
Closed
@abitmore abitmore added this to the 201901 - Feature Release milestone Jan 15, 2019
@MichelSantos MichelSantos mentioned this pull request Feb 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmconrad pmconrad pmconrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
201902 - Feature Release
Development

Successfully merging this pull request may close these issues.
3 participants
@jmjatlanta @pmconrad @abitmore