Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emergency fix for stuck chain release -> master #1451

Merged
merged 5 commits into from
Nov 27, 2018
Merged

Emergency fix for stuck chain release -> master #1451

merged 5 commits into from
Nov 27, 2018

Conversation

pmconrad
Copy link
Contributor

No description provided.

Copy link
Member

@cogutvalera cogutvalera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@pmconrad pmconrad merged commit 5b23099 into master Nov 27, 2018
@oxarbitrage
Copy link
Member

For compassion purposes i got snapshot of the blockchain when it halted in 2 different nodes. One with the fix merged here, i used the master branch and another without the fix(i used the develop branch).

Both nodes were started with the following command:

./programs/witness_node/witness_node --plugins "snapshot market_history" --snapshot-at-block 32599932 --snapshot-to "snap.json"
  • master node created snapshot at block in question, continued getting blocks until it was in sync.
  • develop node created snapshot at block and was not able to continue(expected as fix is not in develop yet)
  • comparison between the 2 snapshot files result in no difference at all, we were after this to confirm the internal database had not changed with the fix before implemented.

@abitmore abitmore added this to the Hotfix-201811-2 milestone Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants