Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move --plugins from application to binary #1427 #1437

Merged
merged 16 commits into from
Jan 20, 2019

Commits on Nov 9, 2018

  1. Allow required plugins

    As far as I can tell, there was no way previously for an application
    to register a plugin and ensure that plugin got loaded -- it would
    be necessary to manually edit the config and specify the plugin be
    loaded.
    
    This is suboptimal; if third party code wishes to track third party
    extensions on the blockchain, the correct way to do this is with a
    plugin, and this third party build should be able to load these
    required plugins regardless of whether the config lists them or not.
    
    This commit adds a boolean parameter to application::register_plugin
    which defaults to false for backwards compatibility; however, if
    set to true, the plugin will automatically be enabled when the app
    initializes.
    nathanielhourt committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    0abcff9 View commit details
    Browse the repository at this point in the history
  2. Clean up plugin loader

    That code was nasty and... kinda wrong. So fix it up all shiny-like.
    
    But I also removed the super annoying default "wanted" plugins list,
    which only causes problems for third parties like me, and in general is
    just poor form. In my opinion, 5220425
    provides a much cleaner way to do this, in a way that is friendly rather
    than hostile to third parties.
    
    Would Be Nice: A generalized plugin conflict system added at the
    abstract_plugin level, so, for example, the elasticsearch plugin can
    conflict account_history and we deal with this in a general fashion
    rather than having this dirty special case check here.
    nathanielhourt committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    b5362ce View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2018

  1. Configuration menu
    Copy the full SHA
    3e683ed View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2018

  1. Configuration menu
    Copy the full SHA
    f5031bd View commit details
    Browse the repository at this point in the history
  2. fix cli wallet test

    oxarbitrage committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    adef6a2 View commit details
    Browse the repository at this point in the history
  3. remove double space line

    oxarbitrage committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    9647ad1 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2018

  1. Configuration menu
    Copy the full SHA
    ce35a79 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2018

  1. remove not needed check

    oxarbitrage committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    58ad814 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2018

  1. fix delayed node

    oxarbitrage committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    7089d2a View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2018

  1. Configuration menu
    Copy the full SHA
    1dd719f View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2018

  1. Configuration menu
    Copy the full SHA
    a8020a7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1326a5c View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2019

  1. remove useless check

    oxarbitrage committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    a590c25 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    caf7f7f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bac55a4 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2019

  1. Configuration menu
    Copy the full SHA
    e198552 View commit details
    Browse the repository at this point in the history