-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move --plugins from application to binary #1427 #1437
Merged
Merged
Commits on Nov 9, 2018
-
As far as I can tell, there was no way previously for an application to register a plugin and ensure that plugin got loaded -- it would be necessary to manually edit the config and specify the plugin be loaded. This is suboptimal; if third party code wishes to track third party extensions on the blockchain, the correct way to do this is with a plugin, and this third party build should be able to load these required plugins regardless of whether the config lists them or not. This commit adds a boolean parameter to application::register_plugin which defaults to false for backwards compatibility; however, if set to true, the plugin will automatically be enabled when the app initializes.
Configuration menu - View commit details
-
Copy full SHA for 0abcff9 - Browse repository at this point
Copy the full SHA 0abcff9View commit details -
That code was nasty and... kinda wrong. So fix it up all shiny-like. But I also removed the super annoying default "wanted" plugins list, which only causes problems for third parties like me, and in general is just poor form. In my opinion, 5220425 provides a much cleaner way to do this, in a way that is friendly rather than hostile to third parties. Would Be Nice: A generalized plugin conflict system added at the abstract_plugin level, so, for example, the elasticsearch plugin can conflict account_history and we deal with this in a general fashion rather than having this dirty special case check here.
Configuration menu - View commit details
-
Copy full SHA for b5362ce - Browse repository at this point
Copy the full SHA b5362ceView commit details
Commits on Nov 14, 2018
-
Merge commit 'refs/pull/1427/head' of https://github.com/bitshares/bi…
…tshares-core into pull1427_2
Configuration menu - View commit details
-
Copy full SHA for 3e683ed - Browse repository at this point
Copy the full SHA 3e683edView commit details
Commits on Nov 15, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f5031bd - Browse repository at this point
Copy the full SHA f5031bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for adef6a2 - Browse repository at this point
Copy the full SHA adef6a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9647ad1 - Browse repository at this point
Copy the full SHA 9647ad1View commit details
Commits on Nov 17, 2018
-
Configuration menu - View commit details
-
Copy full SHA for ce35a79 - Browse repository at this point
Copy the full SHA ce35a79View commit details
Commits on Nov 18, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 58ad814 - Browse repository at this point
Copy the full SHA 58ad814View commit details
Commits on Nov 30, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 7089d2a - Browse repository at this point
Copy the full SHA 7089d2aView commit details
Commits on Dec 5, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 1dd719f - Browse repository at this point
Copy the full SHA 1dd719fView commit details
Commits on Dec 17, 2018
-
Configuration menu - View commit details
-
Copy full SHA for a8020a7 - Browse repository at this point
Copy the full SHA a8020a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1326a5c - Browse repository at this point
Copy the full SHA 1326a5cView commit details
Commits on Jan 16, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a590c25 - Browse repository at this point
Copy the full SHA a590c25View commit details -
Configuration menu - View commit details
-
Copy full SHA for caf7f7f - Browse repository at this point
Copy the full SHA caf7f7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bac55a4 - Browse repository at this point
Copy the full SHA bac55a4View commit details
Commits on Jan 17, 2019
-
Configuration menu - View commit details
-
Copy full SHA for e198552 - Browse repository at this point
Copy the full SHA e198552View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.