Add network mapper from bitshares-1 #1372

pmconrad · 2018-10-13T10:02:27Z

Fix for #1550

Ported from https://github.com/bitshares/bitshares1-core/blob/master/programs/utils/map_bts_network.cpp

cogutvalera

indentation is different: somewhere 2 spaces, somewhere 3 spaces, and somewhere 4 spaces (network_mapper.cpp).

cogutvalera

see comment

cogutvalera · 2018-10-20T19:54:30Z

programs/network_mapper/network_mapper.cpp

+                                  fc::ip::address(), 0, 0,
+                                  my_node_id.get_public_key(),
+                                  signature,
+				  chain_id,


this line is looking ugly

cogutvalera

see comment

cogutvalera · 2018-10-20T20:20:46Z

programs/network_mapper/network_mapper.cpp

-    std::string hostname = endpoint_string.substr(0, colon_pos);
-    return fc::resolve(hostname, port);
-}
-
 int main(int argc, char** argv)


why not to use boost::program_options like in cli_wallet for example ?

in addition IMHO we should have some default values

cogutvalera

after compiling this code, I cannot start witness_node, I see next error:

./programs/witness_node/witness_node
terminate called after throwing an instance of 'boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::bad_any_cast> >'
  what():  boost::bad_any_cast: failed conversion using boost::any_cast
Aborted (core dumped)

abitmore · 2018-10-21T09:18:33Z

@cogutvalera:

boost::bad_any_cast

Please merge latest develop when testing. I believe it's fixed by #1374.

cogutvalera · 2018-10-21T13:58:40Z

@abitmore Thanks ! ok sure will bump now, I believe too that it will help, just thought about this too ...

cogutvalera · 2018-10-21T14:33:02Z

rebase helped !

pmconrad · 2018-10-21T16:42:44Z

Thanks. If whoever tackles #1348 decides that this tool might be handy, we can invest time to reformat and think about boost::program_options.

oxarbitrage · 2018-10-26T14:47:06Z

I wanted to giuve a try to this tool however i am getting the following error with any seed i tried:

alfredo@alfredo-System-Product-Name:~/CLionProjects/pull1372/bitshares-core$ ./programs/network_mapper/network_mapper 4018d7844c78f6a6c41c6a552b898022310fc5dec06da467ee7905a8dad512c8 bts-seed1.abit-more.com:62015
116.239.98.243:62015 ran into an error!
0 checked, 0 active, 0 to do
alfredo@alfredo-System-Product-Name:~/CLionProjects/pull1372/bitshares-core$

alfredo@alfredo-System-Product-Name:~/CLionProjects/pull1372/bitshares-core$ ./programs/network_mapper/network_mapper 4018d7844c78f6a6c41c6a552b898022310fc5dec06da467ee7905a8dad512c8 95.179.137.33:1776
95.179.137.33:1776 ran into an error!
0 checked, 0 active, 0 to do
alfredo@alfredo-System-Product-Name:~/CLionProjects/pull1372/bitshares-core$

I am not running it properly ?

pmconrad · 2018-10-28T18:00:17Z

Hm, seems to be some kind of initialization problem. If you specify two seed nodes (or one with several addresses) it'll work.

…oring out

pmconrad · 2018-10-31T13:22:24Z

Fixed stupid error. Hint: don't use promise.wait(timeout).

ryanRfox · 2019-02-01T17:39:56Z

@pmconrad I modified the PR Description to reference #1550 so I believe it will close that Issue upon merge and leave the original Issue open for now.

oxarbitrage · 2019-02-02T13:58:50Z

I have a hard time understanding the usefulness of this program. Here is a sample log: https://raw.githubusercontent.com/oxarbitrage/logs/master/network-mapper.txt

Can someone direct me to a practical example on what someone can do with this output ?

Another thing, if we merge we need to update the programs README if we add this new program: https://github.com/bitshares/bitshares-core/blob/develop/programs/README.md

dnotestein · 2019-02-02T14:51:35Z

I have a hard time understanding the usefulness of this program. Here is a sample log: https://raw.githubusercontent.com/oxarbitrage/logs/master/network-mapper.txt

It generates .DOT file that can be rendered by graphviz to make images of node connectivity.

The DOT file is created here:
std::ofstream dot_stream((data_dir / "network_graph.dot").string().c_str());

oxarbitrage · 2019-02-02T15:46:49Z

Thank you @dnotestein , makes sense now.

However it seems to not be working, the dot file is not generated:

alfredo@alfredo-System-Product-Name:/tmp/network_map_4018d7844c78f6a6c41c6a552b898022310fc5dec06da467ee7905a8dad512c8$ ls
alfredo@alfredo-System-Product-Name:/tmp/network_map_4018d7844c78f6a6c41c6a552b898022310fc5dec06da467ee7905a8dad512c8$

maybe because of segfault?

Failed to connect 94.130.120.250:51174 - skipping!
2338483ms th_m       network_mapper.cpp:51         start                ] timeout connecting to node 104.237.1.18:1776
Failed to connect 104.237.1.18:1776 - skipping!
terminate called after throwing an instance of 'fc::assert_exception'

Thread 1 "network_mapper" received signal SIGABRT, Aborted.
__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
51	../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007ffff6ab5801 in __GI_abort () at abort.c:79
#2  0x00007ffff74a88fb in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#3  0x00007ffff74aed3a in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#4  0x00007ffff74aed95 in std::terminate() () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5  0x00007ffff74aefe8 in __cxa_throw () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#6  0x00005555556da203 in fc::ecc::public_key::serialize (this=<optimized out>) at /home/alfredo/CLionProjects/pull1372/bitshares-core/libraries/fc/src/crypto/elliptic_secp256k1.cpp:119
#7  0x0000555555632126 in fc::ecc::public_key::operator fc::array<char, 33ul> (this=<optimized out>)
    at /home/alfredo/CLionProjects/pull1372/bitshares-core/libraries/fc/include/fc/crypto/elliptic.hpp:42
#8  main (argc=<optimized out>, argv=<optimized out>) at /home/alfredo/CLionProjects/pull1372/bitshares-core/programs/network_mapper/network_mapper.cpp:243

pmconrad · 2019-02-05T13:41:14Z

Replaced with #1555, see comment there.

pmconrad added 2 commits October 13, 2018 11:57

Ported network mapper from old bitshares

6d274b3

Adapted to lastest fc, ported parallel execution from muse

0e412c5

pmconrad added the 2e Ready for Testing Status indicating the solution is sufficiently developed to begin testing label Oct 13, 2018

abitmore added this to the 201812 - Feature Release milestone Oct 13, 2018

cogutvalera suggested changes Oct 20, 2018

View reviewed changes

cogutvalera suggested changes Oct 21, 2018

View reviewed changes

Fix: waiting for a promise with a timeout can lead to the promise err…

5f699b4

…oring out

oxarbitrage mentioned this pull request Jan 29, 2019

BitShares Network Map #1348

Open

7 tasks

pmconrad mentioned this pull request Feb 5, 2019

Add network mapper from bitshares-1 #1555

Merged

pmconrad closed this Feb 5, 2019

pmconrad removed this from the 201902 - Feature Release milestone Feb 5, 2019

oxarbitrage mentioned this pull request Feb 5, 2019

add network_mapper to programs README for issue #1558 #1559

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add network mapper from bitshares-1 #1372

Add network mapper from bitshares-1 #1372

pmconrad commented Oct 13, 2018 •

edited by ryanRfox

Loading

cogutvalera left a comment

cogutvalera left a comment

cogutvalera Oct 20, 2018

cogutvalera left a comment

cogutvalera Oct 20, 2018 •

edited

Loading

cogutvalera Oct 20, 2018

cogutvalera left a comment

abitmore commented Oct 21, 2018

cogutvalera commented Oct 21, 2018

cogutvalera commented Oct 21, 2018

pmconrad commented Oct 21, 2018

oxarbitrage commented Oct 26, 2018

pmconrad commented Oct 28, 2018

pmconrad commented Oct 31, 2018

ryanRfox commented Feb 1, 2019

oxarbitrage commented Feb 2, 2019

dnotestein commented Feb 2, 2019

oxarbitrage commented Feb 2, 2019

pmconrad commented Feb 5, 2019

Add network mapper from bitshares-1 #1372

Add network mapper from bitshares-1 #1372

Conversation

pmconrad commented Oct 13, 2018 • edited by ryanRfox Loading

cogutvalera left a comment

Choose a reason for hiding this comment

cogutvalera left a comment

Choose a reason for hiding this comment

cogutvalera Oct 20, 2018

Choose a reason for hiding this comment

cogutvalera left a comment

Choose a reason for hiding this comment

cogutvalera Oct 20, 2018 • edited Loading

Choose a reason for hiding this comment

cogutvalera Oct 20, 2018

Choose a reason for hiding this comment

cogutvalera left a comment

Choose a reason for hiding this comment

abitmore commented Oct 21, 2018

cogutvalera commented Oct 21, 2018

cogutvalera commented Oct 21, 2018

pmconrad commented Oct 21, 2018

oxarbitrage commented Oct 26, 2018

pmconrad commented Oct 28, 2018

pmconrad commented Oct 31, 2018

ryanRfox commented Feb 1, 2019

oxarbitrage commented Feb 2, 2019

dnotestein commented Feb 2, 2019

oxarbitrage commented Feb 2, 2019

pmconrad commented Feb 5, 2019

pmconrad commented Oct 13, 2018 •

edited by ryanRfox

Loading

cogutvalera Oct 20, 2018 •

edited

Loading