Fix #584 authorize transactions with non-immediate owner authorities #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
modified the milestones:
Future Consensus-Changing Release,
201811 - Consensus-Upgrade Release
abitmore
force-pushed
the
584-non-immediate-owner
branch
from
72cb34a
to
0592ce3
Compare
|
Rebased to latest develop branch to resolve conflicts. |
abitmore
modified the milestones:
201811 - Consensus-Upgrade Release,
201905 - Consensus-Upgrade Release
pmconrad
force-pushed
the
584-non-immediate-owner
branch
from
0592ce3
to
ac310b1
Compare
|
Rebased on latest hardfork to resolve merge conflict |
|
@jmjatlanta, @oxarbitrage or @xeroc please review this so we can merge it? Because both I and Peter have pushed some code, it's best that another developer can review it. |
jmjatlanta
previously approved these changes
Feb 5, 2019
|
i will want to take a look tomorrow after the feature release is done. thank you. |
xeroc
reviewed
Feb 6, 2019
libraries/chain/include/graphene/chain/protocol/transaction.hpp
Outdated
Show resolved
Hide resolved
oxarbitrage
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #584.
Todo:
- [ ] update proposal tests after implemented Let proposal_update_operation fail if it approves a proposal but the proposal fails to execute #278.update: moved this job to Let proposal_update_operation fail if it approves a proposal but the proposal fails to execute #278.- [ ] fix test cases after Parallel preprocessing of blocks + transactions #1360 is merged- [ ] fix code after Resolve 1371: sorting of public_keys is inefficient #1401 is merged