835 Ubuntu 18.04 Support #1212
835 Ubuntu 18.04 Support #1212
Conversation
README.md
Outdated
| git remote set-head origin --auto | ||
| git pull | ||
| git submodule sync --recursive | ||
| git submodule update --init --recursive |
There was a problem hiding this comment.
Perhaps need one more git submodule update --init --recursive before sync. More info: https://github.com/bitshares/bitshares-core/releases/tag/2.0.180328
README.md
Outdated
| git submodule update --init --recursive | ||
|
|
||
| **NOTE:** BitShares requires a [Boost](http://www.boost.org/) version in the range [1.57 - 1.65]. Versions earlier than | ||
| 1.57 or newer than 1.65 are NOT supported. If your system's Boost version is newer, then you will need to manually build |
There was a problem hiding this comment.
Actually we support 1.65.1
| @@ -49,15 +41,27 @@ To build after all dependencies are installed: | |||
| cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo . | |||
There was a problem hiding this comment.
<LATEST_RELEASE_TAG> has confused some people. Perhaps update it after every release? Or remove that line, then by default master branch will be used (but --version command won't show the correct tag).
There was a problem hiding this comment.
Agreed, let's make it simple for the end user to copy paste the script. I've added a new current_version file containing the text matching the (expected) release tag. I've swapped the for a $variable and inserted a bash script to set variable=$(curl URL)
There was a problem hiding this comment.
curl doesn't work in windows, so I'd avoid that. --version not showing the tag IMHO is acceptable.
There was a problem hiding this comment.
Removed the curl statement and $variable. Replaced with an explicit git checkout master and added a comment about replacing with current release as needed.
README.md
Outdated
| git checkout master | ||
| git remote set-head origin --auto | ||
| git pull | ||
| git submodule update --init --recursive # this command will fail |
There was a problem hiding this comment.
this command will fail is not always true.
There was a problem hiding this comment.
change it to to "this command may fail" will be best, else eliminate the comment?
|
If we merge using the $LATEST_RELEASE_TAG included, we must update our Git Flow document to include this step with each release. |
Update README.md associated with #835