Fix boost 1.66 compatibility #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odify() Current boost will delete an object from a multi_index_container if when modifying that object, the functor throws an exception. This breaks the undo infrastructure when it tries to undo the failed change, but the object is missing. To prevent this, we catch the exception before it reaches boost.
In other words, hopefully this makes travis work
abitmore
modified the milestones:
Future Non-Consensus-Changing Release,
201810 - Non-Consensus-Changing Release
jmjatlanta
suggested changes
Jul 30, 2018
| ); | ||
| if (exc) | ||
| std::rethrow_exception(exc); | ||
| FC_ASSERT(ok, "Could not modify object, most likely a index constraint was violated"); |
jmjatlanta
approved these changes
Jul 30, 2018
abitmore
modified the milestones:
201810 - Non-Consensus-Changing Release,
201808 - Non-Consensus-Changing Release
This was referenced Jul 30, 2018
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #852.
Cherry-picked / rebased from #1126.