set default quote asset_id to 1.3.1 #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In current help message of create_asset, printed in gethelp, gives an example of option with quote asset_id of "1.3.0". This asset id is not a valid one, since the code requires the id to be "1.3.1" on creating a new asset. This change set the default quote asset_id to "1.3.1", so that the gethelp message would give a valid option example.
abitmore
reviewed
Jul 10, 2018
|
I have tried command create_asset and update_asset in cli_wallet. Not sure how to run all the test cases? |
|
run all the tests with:
make sure you end up with also, start a witness node with your changes and synchronize the chain, i understand you are making the change for a cli wallet command but your change is done in the core(asset_ops file) so we need to make sure this does not break anything. |
|
sure, I will run the test and paste the result. BTW, I don't need to sync all the data by running the witness_node, right? Since my machine doesn't hold much memory. Is "Get block..." a symbol for the validation? |
|
The chain_test result is: *** No errors detected And I start a witness_node to connect my testnet(without this change), the console log shows getting a block successfully. |
|
Also I tried to connect to the mainnet, below is the console log: |
|
by default the node will require around 20 gigs of ram, by using |
|
ok, I will schedule the test at the weekend. Not sure how many I could sync. |
oxarbitrage
approved these changes
Jul 11, 2018
|
Thanks for merging this commit. BTW, I am willing to know how to make sure the code works fine? For example, currently I synced block till 2018-03-18. Is this a proof for the code is fine? Do we need other evidence? |
|
Currently, it synced to 2081-07-04 And took 9.6G ram by running the witness_node with --max-ops-per-account 10 set. Not sure how many more it could sync. |
|
I think it is synced with current network and processing transactions. |
|
thanks @RichardWeiYang thats good enough for this. very appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current help message of create_asset, printed in gethelp, gives an
example of option with quote asset_id of "1.3.0". This asset id is
not a valid one, since the code requires the id to be "1.3.1" on
creating a new asset.
This change set the default quote asset_id to "1.3.1", so that the
gethelp message would give a valid option example.