Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove double assert in object_id_type constructor #1128

Merged
merged 1 commit into from
Jul 8, 2018
Merged

remove double assert in object_id_type constructor #1128

merged 1 commit into from
Jul 8, 2018

Conversation

RichardWeiYang
Copy link
Contributor

Looks it is not necessary to assert twice on the same condition.

abitmore
abitmore approved these changes Jul 8, 2018
View reviewed changes
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

oxarbitrage
oxarbitrage approved these changes Jul 8, 2018
View reviewed changes
Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.

@oxarbitrage oxarbitrage merged commit 7fb2c86 into bitshares:develop Jul 8, 2018
@abitmore abitmore mentioned this pull request Aug 4, 2018
Closed
@pmconrad pmconrad mentioned this pull request Feb 1, 2019
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

@abitmore abitmore abitmore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
201808 - Non-Consensus-Changing Release
Development

Successfully merging this pull request may close these issues.
3 participants
@RichardWeiYang @abitmore @oxarbitrage