Range proof mantissa minimum bit length #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a length produced by cli_wallet.
…matic) to 49 (the largest bit length that won't exceed GRAPHENE_MAX_SHARE_SUPPLY).
abitmore
reviewed
Jul 4, 2018
jmjatlanta
reviewed
Jul 5, 2018
There was a problem hiding this comment.
All looks good to me as well. Thanks @christophersanborn.
Note: I'm not marking this approved, as I too would like pmconrad to take a look.
pmconrad
added
2f Testing
pmconrad
reviewed
Jul 17, 2018
tests/cli/main.cpp
Outdated
| generate_block(app1); head_block++; | ||
|
|
||
| // ** Check head block: | ||
| BOOST_MESSAGE("Check that all expected blocks have processed"); |
There was a problem hiding this comment.
This fails to compile for me (Boost-1.60.0):
tests/cli/main.cpp:474:68: error: ‘BOOST_MESSAGE’ was not declared in this scope
BOOST_MESSAGE("Check that all expected blocks have processed");
Changing to BOOST_TEST_MESSAGE works.
There was a problem hiding this comment.
Thanks! Missed that. (Must have older Boost version.)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #480 - "Choice of range proof params in cli wallet reveals transaction magnitude to very narrow range for Blinded transfers" and provides test case of cli_wallet blind transfers.