Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect code in check authorized asset for withdraw_to_account in withdraw_permission_claim_evaluator? #942

Closed
btsabc opened this issue May 22, 2018 · 2 comments

Comments

@btsabc
Copy link

btsabc commented May 22, 2018

const account_object& from = op.withdraw_to_account(d);
const account_object& to = permit.authorized_account(d);
FC_ASSERT( is_authorized_asset( d, to, _asset ) );
FC_ASSERT( is_authorized_asset( d, from, _asset ) );

Line 77 should be:
const account_object& from = op.withdraw_from_account(d);

@abitmore
Copy link
Member

Thanks for the report.

This issue effectively will skip white-list check for the real from account. Seems easy to fix. Let's see if we can fix it in this release.

@abitmore abitmore added the bug label May 22, 2018
@abitmore abitmore self-assigned this May 22, 2018
@abitmore abitmore removed their assignment May 23, 2018
abitmore added a commit that referenced this issue May 23, 2018
Fix withdraw_permission_claim 'from' check #942
@abitmore
Copy link
Member

Fixed with #951.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants