Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing checks when updating an asset's bitasset_data #922

Closed
abitmore opened this issue May 13, 2018 · 1 comment
Closed

Missing checks when updating an asset's bitasset_data #922

abitmore opened this issue May 13, 2018 · 1 comment

Comments

@abitmore
Copy link
Member

When creating an asset, there are checks:

FC_ASSERT( op.bitasset_opts->feed_lifetime_sec > chain_parameters.block_interval &&
op.bitasset_opts->force_settlement_delay_sec > chain_parameters.block_interval );
}
if( op.is_prediction_market )
{
FC_ASSERT( op.bitasset_opts );
FC_ASSERT( op.precision == op.bitasset_opts->short_backing_asset(d).precision );
}

These are missing when updating.

@jmjatlanta jmjatlanta self-assigned this May 16, 2018
@abitmore abitmore changed the title Missing checks when updating an asset's backing asset ID Missing checks when updating an asset's bitasset_data May 17, 2018
@abitmore abitmore added this to the 201805 - Consensus Changing Release milestone May 17, 2018
abitmore added a commit that referenced this issue May 24, 2018
Issues #922 and #931 bitasset_update checks
@abitmore
Copy link
Member Author

Fixed with #932.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants