Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide cli_wallet and delayed_node as Docker image. #837

Closed
Zapata opened this issue Apr 10, 2018 · 7 comments
Closed

Provide cli_wallet and delayed_node as Docker image. #837

Zapata opened this issue Apr 10, 2018 · 7 comments

Comments

@Zapata
Copy link
Member

Zapata commented Apr 10, 2018

In order to easely deploy a cli_wallet and a delayed node, those should be available through a Docker image as the witness node currently is.

An implemnetation could be to update bitshares/bitshares-core to include cli_wallet and delayed_node binaries.

This way we would be able to run:

docker run bitshares/bitshares-core cli_wallet -s wss://eu.openledger.info/ws -H 127.0.0.1:8093

However this will increase the size of the image, an alternative implementation could be to deliver 3 different images result of a different stage on top of a base build image.

Zapata added a commit to Zapata/bitshares-core that referenced this issue Apr 10, 2018
Proposed implementation for: bitshares#837

Impact on image size is minimal, on my machine:
  zapata/bitshares-core        testnet             c0116c379fc2          37 hours ago         1.25GB
  zapata/bitshares-core        latest                40e7c3cd117e        39 hours ago        1.4GB
  bitshares/bitshares-core    testnet             f4d9edd8646d        12 days ago         1.27GB

Note that the sized showed on Docker hub is 3x off the reality (see docker/hub-feedback#331)
@Zapata Zapata closed this as completed Apr 10, 2018
@Zapata Zapata reopened this Apr 10, 2018
@xeroc
Copy link
Member

xeroc commented Apr 11, 2018

This requires that the cli_wallet is built statically .. then a docker container can be built that only has cli_wallet ... but then again, you could as well deliver the binary instead of a container ..

@Zapata
Copy link
Member Author

Zapata commented Apr 11, 2018

I don't see why you need static compilation for that, the proposed pull request works for me and match the need. Could you elaborate?

A docker container is mandatory to use orchestrators like kubernetes, which greatly help for auto scaling, and zero down time deliveries. I personally use Rancher for that.

Imho static compilation could be useful to build a docker image "from scratch" (no base image) to reduce container size and attack surface.

@apasia-tech
Copy link

"delayed_node binaries" - Far as I'm informed, delayed_node binary is obsolete and currently it's being run by a switch through a witness_node binary. Maybe @abitmore or @xeroc can confirm this ?

@abitmore
Copy link
Member

@apasia-tech for backward compatibility, delayed_node binary still works, but won't have new features introduced to witness_node only.

witness_node can be configured to run as a delayed node with --plugins delayed_node.

@Zapata
Copy link
Member Author

Zapata commented Apr 22, 2018

@abitmore I think I can remove delayed_node from the Docker image as we don't care of backward compabitlity there.

@abitmore
Copy link
Member

@Zapata I agree.

@oxarbitrage
Copy link
Member

closed by #848

jmjatlanta pushed a commit to jmjatlanta/bitshares-core that referenced this issue Apr 27, 2018
Proposed implementation for: bitshares#837

Impact on image size is minimal, on my machine:
  zapata/bitshares-core        testnet             c0116c379fc2          37 hours ago         1.25GB
  zapata/bitshares-core        latest                40e7c3cd117e        39 hours ago        1.4GB
  bitshares/bitshares-core    testnet             f4d9edd8646d        12 days ago         1.27GB

Note that the sized showed on Docker hub is 3x off the reality (see docker/hub-feedback#331)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants