Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters to configure log rotation #805

Closed
abitmore opened this issue Apr 3, 2018 · 2 comments
Closed

Add parameters to configure log rotation #805

abitmore opened this issue Apr 3, 2018 · 2 comments

Comments

@abitmore
Copy link
Member

abitmore commented Apr 3, 2018

Currently log rotation of witness_node is hard-coded as

  • one log file per hour and
  • keep only log files created within one day.

It's better to change them to configurable for easier data analysis and trouble shooting. I personally want to keep the log files for at least one week.

Related code is here.

            // construct a default file appender config here
            // filename will be taken from ini file, everything else hard-coded here
            fc::file_appender::config file_appender_config;
            file_appender_config.filename = file_name;
            file_appender_config.flush = true;
            file_appender_config.rotate = true;
            file_appender_config.rotation_interval = fc::hours(1);
            file_appender_config.rotation_limit = fc::days(1);
@abitmore abitmore added this to the Future Non-Consensus-Changing Release milestone Apr 3, 2018
@windycrypto
Copy link
Member

Pls check this pr?
#840

@abitmore abitmore modified the milestones: Future Non-Consensus-Changing Release, 201805 - Non-Consensus-Changing Release Apr 11, 2018
oxarbitrage added a commit that referenced this issue Apr 15, 2018
Fix #805, Add parameters to configure log rotation
@abitmore
Copy link
Member Author

Merged #840. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants