Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in terminate_inactive_connections_loop function in node.cpp #721

Closed
abitmore opened this issue Mar 14, 2018 · 1 comment
Closed

Bug in terminate_inactive_connections_loop function in node.cpp #721

abitmore opened this issue Mar 14, 2018 · 1 comment
Labels
bug
Milestone
201803 Non-Consen...

Comments

@abitmore
Copy link
Member

As reported by @rabbitHX in steemit/steem#2229, the break at line #1391 of node.cpp seems wrong.

this break cause a escape from "for" so that the bad connection is not "push_back" into peers_to_disconnect_forcibly.

It also prevents other connections from being checked.
@abitmore abitmore added the bug label Mar 14, 2018
@abitmore abitmore changed the title Bug in node.cpp Bug in terminate_inactive_connections_loop function in node.cpp Mar 14, 2018
abitmore added a commit that referenced this issue Mar 14, 2018
@abitmore
Fix #721 disconnect a peer due to request timeout
56f0ba2
@abitmore abitmore mentioned this issue Mar 14, 2018
Merged
abitmore added a commit that referenced this issue Mar 16, 2018
@abitmore
Merge pull request #722 from bitshares/abitmore-patch-1
91ae7c9 
Fix #721 disconnect a peer due to request timeout
@oxarbitrage
Copy link
Member

closed by #722

xeroc pushed a commit that referenced this issue Mar 21, 2018
@abitmore @xeroc
Fix #721 disconnect a peer due to request timeout
59b6a15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
201803 Non-Consensus-Changing Release
Development

No branches or pull requests
2 participants
@abitmore @oxarbitrage