Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Market fill order history: remove old entries #454

Closed
abitmore opened this issue Nov 1, 2017 · 0 comments
Closed

Market fill order history: remove old entries #454

abitmore opened this issue Nov 1, 2017 · 0 comments
Labels
performance plugin
Milestone
201712 - Non-Cons...

Comments

@abitmore
Copy link
Member

abitmore commented Nov 1, 2017

To save RAM, we can keep only the last X entries, or entries of last Y days, which has more data.

There was a mechanism that keeps only last 100 entries, which was not good enough so caused some trouble, so has been removed in #255.
@abitmore abitmore mentioned this issue Nov 10, 2017
Merged
@abitmore abitmore self-assigned this Nov 13, 2017
abitmore added a commit to abitmore/bitshares-core that referenced this issue Nov 13, 2017
@abitmore
Market his: prune old order matching data. bitshares#454
5ee5642 
This commit introduces two new options to market_history_plugin:
* `max-order-his-records-per-market`:
  Will only store this amount of matched orders for each market in order
  history for querying, or those meet the other option, which has more data.
  (default: 1000)
* `max-order-his-seconds-per-market`:
  Will only store matched orders in last X seconds for each market in order
  history for querying, or those meet the other option, which has more data.
  (default: 259200 (3 days))
@abitmore abitmore mentioned this issue Nov 13, 2017
Merged
@abitmore abitmore added this to the Next Non-Consensus-Changing Release - 201712 milestone Nov 27, 2017
@abitmore abitmore mentioned this issue Nov 27, 2017
Closed
@abitmore abitmore removed their assignment Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance plugin
Projects
None yet
Milestone
201712 - Non-Consensus-Changing Release
Development

No branches or pull requests
2 participants
@abitmore @oxarbitrage