Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"PERLLIB=${CMAKE_CURRENT_SOURCE_DIR}" should be "PERLLIB=${CMAKE_CURRENT_BINARY_DIR}" #1418

Closed
z16166 opened this issue Nov 5, 2018 · 5 comments
Assignees
Labels
2c Ready for Development Status indicating the Requirements are sufficent to begin designing a solution 3d Bug Classification indicating the existing implementation does not match the intention of the design 6 Build Impact flag identifying the build process 9a Tiny Effort estimation indicating TBD good first issue

Comments

@z16166
Copy link

z16166 commented Nov 5, 2018

The following line in libraries/wallet/CMakeLists.txt
PERLLIB=${CMAKE_CURRENT_SOURCE_DIR}
should be
PERLLIB=${CMAKE_CURRENT_BINARY_DIR}

otherwise the doxygen build will complain " Can't locate doxygen/perlmod/DoxyDocs.pm" in Ubuntu 18.04 TLS.

because the actual full path of DoxyDocs.pm is "BitShares/build/libraries/wallet/doxygen/perlmod/DoxyDocs.pm" if the cmake build dir is "BitShares/build".

@z16166
Copy link
Author

z16166 commented Nov 5, 2018

#835
steemit/steem@071f6a9

@pmconrad pmconrad added good first issue 2c Ready for Development Status indicating the Requirements are sufficent to begin designing a solution 3d Bug Classification indicating the existing implementation does not match the intention of the design 6 Build Impact flag identifying the build process 9a Tiny Effort estimation indicating TBD labels Nov 6, 2018
@pmconrad pmconrad added this to the 201812 - Feature Release milestone Nov 6, 2018
@jmjatlanta jmjatlanta self-assigned this Jan 24, 2019
@jmjatlanta
Copy link
Contributor

I have attempted to replicate the issue and am unable. My environment is a little different (Ubuntu 18.10).

Could you please give me the steps to recreate the issue? Please also include the output from cmake. Thank you.

Additional info: I tried with and without the suggested change to the PERLLIB line in libraries/wallet/CMakeLists.txt, and both worked fine. Change is in the jmj_1418 branch, awaiting problem verification before a PR is created.

@abitmore
Copy link
Member

@jmjatlanta have you tried out-of-source build?

mkdir build
cd build
cmake ..
make

@jmjatlanta
Copy link
Contributor

jmjatlanta commented Jan 24, 2019

@jmjatlanta have you tried out-of-source build?

Just tried. Still works for me (unfortunately).

Update I tried it with a fresh clone of the codebase, and out-of-source build, and it failed. Evidently I was not cleaning my environment totally.

oxarbitrage added a commit that referenced this issue Jan 25, 2019
Fixes #1418 - Fix CMake Doxygen Perl reference
@oxarbitrage
Copy link
Member

closed by #1539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2c Ready for Development Status indicating the Requirements are sufficent to begin designing a solution 3d Bug Classification indicating the existing implementation does not match the intention of the design 6 Build Impact flag identifying the build process 9a Tiny Effort estimation indicating TBD good first issue
Projects
None yet
Development

No branches or pull requests

5 participants