Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminate block production loop when shutting down witness plugin #1314

Closed
5 of 9 tasks
abitmore opened this issue Sep 9, 2018 · 9 comments
Closed
5 of 9 tasks

Terminate block production loop when shutting down witness plugin #1314

abitmore opened this issue Sep 9, 2018 · 9 comments
Labels
2c Ready for Development Status indicating the Requirements are sufficent to begin designing a solution 3d Bug Classification indicating the existing implementation does not match the intention of the design 4b Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform 6 UX Impact flag identifying the User Interface (UX) 9b Small Effort estimation indicating TBD
Milestone
201810 - Feature ...

Comments

@abitmore
Copy link
Member

abitmore commented Sep 9, 2018 •
edited by ryanRfox
Loading

Bug Description
Currently nothing is done when shutting down witness plugin. Actually we need to terminate the production loop, otherwise it often causes segfault.

bitshares-core/libraries/plugins/witness/witness.cpp

Lines 146 to 149 in 67166ca

void witness_plugin::plugin_shutdown()
{
// nothing to do
}

bitshares-core/libraries/plugins/witness/witness.cpp

Lines 175 to 177 in 67166ca

_block_production_task = fc::schedule([this]{block_production_loop();},
next_wakeup, "Witness Block Production");
}

CORE TEAM TASK LIST

  • Evaluate / Prioritize Bug Report
  • Refine User Stories / Requirements
  • Define Test Cases
    • Assigned: @cogutvalera
    • Estimate: 2 hours
    • Remittance: Core Team weeks 42-43
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore added 2c Ready for Development Status indicating the Requirements are sufficent to begin designing a solution 3d Bug Classification indicating the existing implementation does not match the intention of the design 4b Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform 9b Small Effort estimation indicating TBD labels Sep 9, 2018
@cogutvalera
Copy link
Member

@ryanRfox I want to claim this issue.

Thanks !

@ryanRfox ryanRfox added the 6 UX Impact flag identifying the User Interface (UX) label Sep 10, 2018
@ryanRfox
Copy link
Contributor

Assigned @cogutvalera to this issues, as he has done related work with the quit() routine. Please include an estimate so @bitshares/core-dev can review prior to beginning development. Thanks

@cogutvalera
Copy link
Member

cogutvalera commented Sep 11, 2018 •
edited
Loading

@ryanRfox my estimation for this issue is approximately 2 hours

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Sep 17, 2018
@cogutvalera
Terminate block production loop when shutting down witness plugin bit…
14e828a 
…shares#1314
@cogutvalera cogutvalera mentioned this issue Sep 17, 2018
Merged
cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Oct 3, 2018
@cogutvalera
Terminate block production loop when shutting down witness plugin bit…
109c7ce 
…shares#1314
abitmore added a commit that referenced this issue Oct 8, 2018
@abitmore
Merge pull request #1332 from cogutvalera/issue_1314
67f313d 
Terminate block production loop when shutting down witness plugin #1314
@abitmore
Copy link
Member Author

abitmore commented Oct 8, 2018

Fixed by #1332.

@abitmore abitmore closed this as completed Oct 8, 2018
@cogutvalera
Copy link
Member

Thanks !

@pmconrad pmconrad reopened this Oct 10, 2018
@pmconrad
Copy link
Contributor

@cogutvalera I'm getting a compiler warning:

libraries/plugins/witness/witness.cpp: In member function ‘graphene::witness_plugin::block_production_condition::block_production_condition_enum graphene::witness_plugin::witness_plugin::block_production_loop()’:
libraries/plugins/witness/witness.cpp:214:10: warning: enumeration value ‘shutdown’ not handled in switch [-Wswitch]

Please fix.

@cogutvalera
Copy link
Member

cogutvalera commented Oct 10, 2018 •
edited
Loading

Sure. Thanks !

@cogutvalera cogutvalera mentioned this issue Oct 10, 2018
Merged
@cogutvalera
Copy link
Member

PR #1364

pmconrad added a commit that referenced this issue Oct 12, 2018
@pmconrad
Merge pull request #1364 from cogutvalera/issue_1314
88167ad 
Terminate block production loop when shutting down witness plugin #1314
@cogutvalera
Copy link
Member

Thanks !

@TheTaconator TheTaconator mentioned this issue Oct 15, 2018
Closed
@ryanRfox ryanRfox mentioned this issue Feb 1, 2019
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2c Ready for Development Status indicating the Requirements are sufficent to begin designing a solution 3d Bug Classification indicating the existing implementation does not match the intention of the design 4b Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform 6 UX Impact flag identifying the User Interface (UX) 9b Small Effort estimation indicating TBD
Projects
None yet
Milestone
201810 - Feature Release
Development

No branches or pull requests
4 participants
@pmconrad @abitmore @ryanRfox @cogutvalera