Skip to content

provide temp flag for outside libs to detect multi-backend preview #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Titus-von-Koeller merged 2 commits into from
Jun 21, 2024
Merged

provide temp flag for outside libs to detect multi-backend preview #1243

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
971778c
provide temp flag for outside libs to detect multi-backend preview
Titus-von-Koeller Jun 6, 2024
66cff09
fix typo in comment
Titus-von-Koeller Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions bitsandbytes/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@
from .cextension import lib
from .nn import modules

# NOTE: this is a temporary flag to allow outside libraries to employ conditional logic while the refactor is still in
# alpha/beta: sth like `if getattr(bitsandbytes, "multi-backend-refactor-preview", False): do sth`
Comment thread
Titus-von-Koeller marked this conversation as resolved.
Outdated
# the getattr() call above would default to False and any string evaluates to True. This way we have temporary thing
# that we can remove in Transformers with the next release after the official BNB multi-platform release; then
# eventually making it the new default (e.g. just remove if statement and dedent in Transformers)
is_multi_backend_refactor_preview = "TO BE REMOVED ONCE MERGED TO `main`" # bool evals to True for str
Comment on lines +23 to +28

@akx akx Jun 6, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we wanted to make this a more permanent feature (and I don't see why not), it could just be e.g. features = {"multi_backend"}...


# Always register the CPU backend.
register_backend("cpu", CPUBackend())

Expand Down