Skip to content

Fix usage of BNB_CUDA_VERSION for manual override #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matthewdouglas wants to merge 2 commits into from
Closed

Fix usage of BNB_CUDA_VERSION for manual override #1017

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1be5a7
Fix usage of BNB_CUDA_VERSION for manual override
Feb 2, 2024
9dfbe3a
Merge branch 'TimDettmers:main' into fix-cuda-override
matthewdouglas Feb 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bitsandbytes/cuda_setup/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def manual_override(self):
)
binary_name = self.binary_name.rsplit(".", 1)[0]
suffix = ".so" if os.name != "nt" else ".dll"
self.binary_name = binary_name[:-3] + f'{os.environ["BNB_CUDA_VERSION"]}.{suffix}'
self.binary_name = binary_name[:-3] + f'{os.environ["BNB_CUDA_VERSION"]}{suffix}'

def run_cuda_setup(self):
self.initialized = True
Expand All @@ -143,7 +143,7 @@ def run_cuda_setup(self):
suffix = ".so" if os.name != "nt" else ".dll"
try:
if not binary_path.exists():
self.add_log_entry(f"CUDA SETUP: Required library version not found: {binary_name}. Maybe you need to compile it from source?")
self.add_log_entry(f"CUDA SETUP: Required library version not found: {self.binary_name}. Maybe you need to compile it from source?")
legacy_binary_name = f"libbitsandbytes_cpu{suffix}"
self.add_log_entry(f"CUDA SETUP: Defaulting to {legacy_binary_name}...")
binary_path = package_dir / legacy_binary_name
Expand Down