Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go19 backward compatibility #55

Merged
merged 10 commits into from
Aug 29, 2017
Merged

Go19 backward compatibility #55

merged 10 commits into from
Aug 29, 2017

Conversation

willf
Copy link
Collaborator

@willf willf commented Aug 28, 2017

Add support for Go 1.9 bits, but keep backward compatibility

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.893% when pulling e2d3b02 on go19-backward-compatibility into 988f4f2 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 96.887% when pulling e50f633 on go19-backward-compatibility into 988f4f2 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 96.887% when pulling 137ee1a on go19-backward-compatibility into 988f4f2 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 96.887% when pulling b77e40d on go19-backward-compatibility into 988f4f2 on master.

@willf willf requested a review from lemire August 28, 2017 17:08
@willf
Copy link
Collaborator Author

willf commented Aug 28, 2017

Hi @lemire

Here is a version that continues to support 1.8 (and maybe earlier, but the make qa script requires 1.8 or higher).

Which version do you think it would be better to keep, this or the just 1.9 version?

I think this is better, tho a bit sloppy. When the next version of Go comes out, I might change some function signatures and require 1.9.

@lemire
Copy link
Member

lemire commented Aug 28, 2017

I think that backward compatibility is good to have, at least temporarily. It is not like anyone has a strong incentive to stick with an old version of Go for years...

@willf willf merged commit d860f34 into master Aug 29, 2017
@willf willf deleted the go19-backward-compatibility branch August 29, 2017 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants