Fixing various issues #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willf
added a commit
that referenced
this pull request
Feb 14, 2014
Fixing various issues -- looks great
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously stated, I think that the code has to take into account that len(v) is an int. So, while it makes perfect sense to use uint as indexes, the underlying array should have a length of type int.
I also think that an implicit assumption in the code is that uint is identical to uint64. This may very well be true for all practical purposes, but you could conceivably use this code on a 32-bit platform where this would not be true.
I also think I made the JSON unmarshalling code cleaner.
I think I caught a few typos in the unit tests.