Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update pyyaml and snowflake-sqlalchemy dependencies #482

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

diegoquintanav
Copy link

@diegoquintanav diegoquintanav commented Sep 8, 2023

Description

How was the change tested

All existing tests passing. New dependencies break support for python>=3.6.3,<3.7.0

Details

============================= test session starts ==============================
platform linux -- Python 3.10.9, pytest-7.0.1, pluggy-1.0.0
rootdir: /home/diego/Code/playground/dbt-sugar-installation/dbt-sugar, configfile: pyproject.toml
plugins: dictsdiff-0.5.8, mock-3.6.1, datafiles-2.0.1, sugar-0.9.6, cov-2.12.1
collected 116 items

tests/audit_task_test.py ............                                    [ 10%]
tests/base_task_test.py ..                                               [ 12%]
tests/bootstrap_task_test.py ..                                          [ 13%]
tests/cli_ui_test.py .........                                           [ 21%]
tests/clickhouse_test.py ...                                             [ 24%]
tests/config_test.py ...............                                     [ 37%]
tests/dbt_client_test.py .                                               [ 37%]
tests/doc_task_test.py ...............................................   [ 78%]
tests/handle_test.py ..                                                  [ 80%]
tests/postgres_test.py ......                                            [ 85%]
tests/profile_test.py ............                                       [ 95%]
tests/snowflake_test.py ...                                              [ 98%]
tests/utils_test.py ..                                                   [100%]

=============================== warnings summary ===============================
tests/bootstrap_task_test.py::test_add_or_update_model_descriptor_placeholders
tests/doc_task_test.py::test_run_excluded_model
tests/postgres_test.py::test_generate_connection
tests/postgres_test.py::test_get_columns_from_table
tests/postgres_test.py::test_run_test_check_query[unique-schema-table-column-result0]
tests/postgres_test.py::test_run_test_check_query[not_null-schema-table-column-result1]
tests/postgres_test.py::test_run_test[unique-public-my_first_dbt_model-question-False]
tests/postgres_test.py::test_run_test[not_null-public-my_first_dbt_model-question-True]
  /home/diego/Code/playground/dbt-sugar-installation/dbt-sugar/dbt_sugar/core/connectors/postgres_connector.py:31: SADeprecationWarning: Calling URL() directly is deprecated and will be disabled in a future release.  The public constructor for URL is now the URL.create() method.
    self.connection_url = sqlalchemy.engine.url.URL(

tests/bootstrap_task_test.py::test_add_or_update_model_descriptor_placeholders
tests/postgres_test.py::test_get_columns_from_table
  /home/diego/Code/playground/dbt-sugar-installation/dbt-sugar/dbt_sugar/core/connectors/base.py:45: SADeprecationWarning: The from_engine() method on Inspector is deprecated and will be removed in a future release.  Please use the sqlalchemy.inspect() function on an Engine or Connection in order to acquire an Inspector. (deprecated since: 1.4)
    inspector = sqlalchemy.engine.reflection.Inspector.from_engine(self.engine)

tests/clickhouse_test.py::test_generate_connection
tests/clickhouse_test.py::test_execute_and_check[unique-schema-table-column-result0]
tests/clickhouse_test.py::test_execute_and_check[not_null-schema-table-column-result1]
  /home/diego/Code/playground/dbt-sugar-installation/dbt-sugar/dbt_sugar/core/connectors/clickhouse_connector.py:31: SADeprecationWarning: Calling URL() directly is deprecated and will be disabled in a future release.  The public constructor for URL is now the URL.create() method.
    self.connection_url = sqlalchemy.engine.url.URL(

tests/postgres_test.py::test_run_test[unique-public-my_first_dbt_model-question-False]
  /home/diego/Code/playground/dbt-sugar-installation/dbt-sugar/dbt_sugar/core/connectors/base.py:82: RemovedIn20Warning: Deprecated API features detected! These feature(s) are not compatible with SQLAlchemy 2.0. To prevent incompatible upgrades prior to updating applications, ensure requirements files are pinned to "sqlalchemy<2.0". Set environment variable SQLALCHEMY_WARN_20=1 to show all deprecation warnings.  Set environment variable SQLALCHEMY_SILENCE_UBER_WARNING=1 to silence this message. (Background on SQLAlchemy 2.0 at: https://sqlalche.me/e/b8d9)
    result = cursor.execute(query).fetchone()

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================= 116 passed, 14 warnings in 2.76s =======================

Issue Information

(If your PR addresses or closes a GitHub issue please write "Closes #<issue_number>" or something like that).

Closes #475
Closes #481

Checklist

(Ideally, all boxes are checked by the time we merged the PR, if you don't know how to do any of these don't hesitate to say so in the PR and we'll help you out.)

  • I formatted my PR name according to CONTRIBUTING.md
  • I added a news fragment to help populating the changelog as encouraged in CONTRIBUTING.md
  • I added "Closes #<issue_number>" in the "Issue Information" section (if no issue, feel free to tick thick the box anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant