remove some lodash calls

packages/bitcore-lib-cash/lib/block/block.js

@@ -22,7 +22,7 @@ function Block(arg) {
   if (!(this instanceof Block)) {
     return new Block(arg);
   }
-  _.extend(this, Block._from(arg));
+  Object.assign(this, Block._from(arg));
   return this;
 }
 

packages/bitcore-lib-cash/lib/block/merkleblock.js

@@ -61,7 +61,7 @@ function MerkleBlock(arg) {
   } else {
     throw new TypeError('Unrecognized argument for MerkleBlock');
   }
-  _.extend(this,info);
+  Object.assign(this, info);
   this._flagBitsUsed = 0;
   this._hashesUsed = 0;
 

packages/bitcore-lib-cash/lib/encoding/base58.js

@@ -1,6 +1,5 @@
 'use strict';
 
-var _ = require('lodash');
 var bs58 = require('bs58');
 var buffer = require('buffer');
 
@@ -26,7 +25,7 @@ Base58.validCharacters = function validCharacters(chars) {
   if (buffer.Buffer.isBuffer(chars)) {
     chars = chars.toString();
   }
-  return _.every(_.map(chars, function(char) { return _.includes(ALPHABET, char); }));
+  return [...chars].every(c => ALPHABET.includes(c));
 };
 
 Base58.prototype.set = function(obj) {

packages/bitcore-lib-cash/lib/errors/index.js

@@ -30,7 +30,7 @@ var traverseNode = function(parent, errorDefinition) {
 
 /* jshint latedef: false */
 var childDefinitions = function(parent, childDefinitions) {
-  _.each(childDefinitions, function(childDefinition) {
+  childDefinitions.forEach((childDefinition) => {
     traverseNode(parent, childDefinition);
   });
 };

packages/bitcore-lib-cash/lib/hdprivatekey.js

@@ -74,7 +74,7 @@ function HDPrivateKey(arg) {
 HDPrivateKey.isValidPath = function(arg, hardened) {
   if (_.isString(arg)) {
     var indexes = HDPrivateKey._getDerivationIndexes(arg);
-    return indexes !== null && _.every(indexes, HDPrivateKey.isValidPath);
+    return indexes !== null && indexes.every(HDPrivateKey.isValidPath);
   }
 
   if (_.isNumber(arg)) {
@@ -99,11 +99,11 @@ HDPrivateKey._getDerivationIndexes = function(path) {
   var steps = path.split('/');
 
   // Special cases:
-  if (_.includes(HDPrivateKey.RootElementAlias, path)) {
+  if (HDPrivateKey.RootElementAlias.includes(path)) {
     return [];
   }
 
-  if (!_.includes(HDPrivateKey.RootElementAlias, steps[0])) {
+  if (!HDPrivateKey.RootElementAlias.includes(steps[0])) {
     return null;
   }
 

packages/bitcore-lib-cash/lib/hdpublickey.js

@@ -75,7 +75,7 @@ function HDPublicKey(arg) {
 HDPublicKey.isValidPath = function(arg) {
   if (_.isString(arg)) {
     var indexes = HDPrivateKey._getDerivationIndexes(arg);
-    return indexes !== null && _.every(indexes, HDPublicKey.isValidPath);
+    return indexes !== null && indexes.every(HDPublicKey.isValidPath);
   }
 
   if (_.isNumber(arg)) {
@@ -184,7 +184,7 @@ HDPublicKey.prototype._deriveWithNumber = function(index, hardened) {
 
 HDPublicKey.prototype._deriveFromString = function(path) {
   /* jshint maxcomplexity: 8 */
-  if (_.includes(path, "'")) {
+  if (path.includes("'")) {
     throw new hdErrors.InvalidIndexCantDeriveHardened();
   } else if (!HDPublicKey.isValidPath(path)) {
     throw new hdErrors.InvalidPath(path);

packages/bitcore-lib-cash/lib/opcode.js

@@ -262,7 +262,7 @@ for (var k in Opcode.map) {
 }
 
 // Easier access to opcodes
-_.extend(Opcode, Opcode.map);
+Object.assign(Opcode, Opcode.map);
 
 /**
  * @returns true if opcode is one of OP_0, OP_1, ..., OP_16

packages/bitcore-lib-cash/lib/transaction/sighash.js

@@ -37,7 +37,7 @@ var sighashForForkId = function(transaction, sighashType, inputNumber, subscript
   function GetPrevoutHash(tx) {
     var writer = new BufferWriter()
 
-    _.each(tx.inputs, function(input) {
+    tx.inputs.forEach((input) => {
         writer.writeReverse(input.prevTxId);
         writer.writeUInt32LE(input.outputIndex);
     });
@@ -50,7 +50,7 @@ var sighashForForkId = function(transaction, sighashType, inputNumber, subscript
   function GetSequenceHash(tx) {
     var writer = new BufferWriter()
 
-    _.each(tx.inputs, function(input) {
+    tx.inputs.forEach((input) => {
       writer.writeUInt32LE(input.sequenceNumber);
     });
 
@@ -63,7 +63,7 @@ var sighashForForkId = function(transaction, sighashType, inputNumber, subscript
     var writer = new BufferWriter()
 
     if ( _.isUndefined(n)) {
-      _.each(tx.outputs, function(output) {
+      tx.outputs.forEach((output) => {
         output.toBufferWriter(writer);
       });
     } else {

packages/bitcore-lib-cash/lib/transaction/transaction.js

@@ -1085,7 +1085,7 @@ Transaction.prototype._calculateSize = function() {
 
 Transaction.prototype._removeOutput = function(index) {
   var output = this.outputs[index];
-  this.outputs = _.without(this.outputs, output);
+  this.outputs = this.outputs.filter(x => x !== output);
   this._outputAmount = undefined;
 };
 
@@ -1193,7 +1193,7 @@ Transaction.prototype.removeInput = function(txId, outputIndex) {
     throw new errors.Transaction.InvalidIndex(index, this.inputs.length);
   }
   var input = this.inputs[index];
-  this.inputs = _.without(this.inputs, input);
+  this.inputs = this.inputs.filter(x => x !== input);
   this._inputAmount = undefined;
   this._updateChangeOutput();
 };

packages/bitcore-lib-cash/lib/uri.js

@@ -1,6 +1,5 @@
 'use strict';
 
-var _ = require('lodash');
 var URL = require('url');
 
 var Address = require('./address');
@@ -179,7 +178,7 @@ URI.prototype.toObject = URI.prototype.toJSON = function toObject() {
       json[m] = this[m].toString();
     }
   }
-  _.extend(json, this.extras);
+  Object.assign(json, this.extras);
   return json;
 };
 
@@ -202,7 +201,7 @@ URI.prototype.toString = function() {
   if (this.r) {
     query.r = this.r;
   }
-  _.extend(query, this.extras);
+  Object.assign(query, this.extras);
 
   return URL.format({
     protocol: Networks.get(this.network ,'name').prefix + ':',

packages/bitcore-lib-cash/test/crypto/signature.js

@@ -1,6 +1,5 @@
 'use strict';
 
-var _ = require('lodash');
 var should = require('chai').should();
 var bitcore = require('../..');
 var BN = bitcore.crypto.BN;
@@ -330,7 +329,7 @@ describe('Signature', function() {
         [(Signature.SIGHASH_ANYONECANPAY | Signature.SIGHASH_SINGLE) + 1, false],
         [(Signature.SIGHASH_ANYONECANPAY | Signature.SIGHASH_ALL) - 1, false],
       ];
-      _.each(testCases, function(testCase) {
+      testCases.forEach((testCase) => {
         sig.nhashtype = testCase[0];
         sig.hasDefinedHashtype().should.equal(testCase[1]);
       });

packages/bitcore-lib-cash/test/hdkeys.js

@@ -10,7 +10,6 @@
 /* jshint maxstatements: 100 */
 /* jshint unused: false */
 
-var _ = require('lodash');
 var should = require('chai').should();
 var expect = require('chai').expect;
 var sinon = require('sinon');
@@ -23,7 +22,7 @@ describe('HDKeys building with static methods', function() {
   var classes = [HDPublicKey, HDPrivateKey];
   var clazz, index;
 
-  _.each(classes, function(clazz) {
+  classes.forEach((clazz) => {
     var expectStaticMethodFail = function(staticMethod, argument, message) {
       expect(clazz[staticMethod].bind(null, argument)).to.throw(message);
     };

packages/bitcore-lib-cash/test/hdprivatekey.js

@@ -313,7 +313,7 @@ describe('HDPrivate key interface', function() {
     it('toObject leaves no Buffer instances', function() {
       var privKey = new HDPrivateKey(xprivkey);
       var object = privKey.toObject();
-      _.each(_.values(object), function(value) {
+      Object.values(object).forEach(value => {
         expect(BufferUtil.isBuffer(value)).to.equal(false);
       });
     });

packages/bitcore-lib-cash/test/transaction/input/input.js

@@ -2,7 +2,6 @@
 
 var should = require('chai').should();
 var expect = require('chai').expect;
-var _ = require('lodash');
 
 var bitcore = require('../../..');
 var errors = bitcore.errors;
@@ -53,7 +52,7 @@ describe('Transaction.Input', function() {
 
   it('has abstract methods: "getSignatures", "isFullySigned", "addSignature", "clearSignatures"', function() {
     var input = new Input(output);
-    _.each(['getSignatures', 'isFullySigned', 'addSignature', 'clearSignatures'], function(method) {
+    ['getSignatures', 'isFullySigned', 'addSignature', 'clearSignatures'].forEach((method) => {
       expect(function() {
         return input[method]();
       }).to.throw(errors.AbstractMethodInvoked);

packages/bitcore-lib-cash/test/transaction/input/multisig.js

@@ -3,7 +3,6 @@
 
 var should = require('chai').should();
 var expect = require('chai').expect;
-var _ = require('lodash');
 
 var bitcore = require('../../..');
 var Transaction = bitcore.Transaction;
@@ -71,14 +70,14 @@ describe('MultiSigInput', function() {
       .to(address, 1000000);
     var input = transaction.inputs[0];
 
-    _.every(input.publicKeysWithoutSignature(), function(publicKeyMissing) {
+    input.publicKeysWithoutSignature().every(publicKeyMissing => {
       var serialized = publicKeyMissing.toString();
       return serialized === public1.toString() ||
               serialized === public2.toString() ||
               serialized === public3.toString();
     }).should.equal(true);
     transaction.sign(privateKey1);
-    _.every(input.publicKeysWithoutSignature(), function(publicKeyMissing) {
+    input.publicKeysWithoutSignature().every(publicKeyMissing => {
       var serialized = publicKeyMissing.toString();
       return serialized === public2.toString() ||
               serialized === public3.toString();

packages/bitcore-lib-cash/test/transaction/input/multisigscripthash.js

@@ -3,7 +3,6 @@
 
 var should = require('chai').should();
 var expect = require('chai').expect;
-var _ = require('lodash');
 
 var bitcore = require('../../..');
 var Transaction = bitcore.Transaction;
@@ -54,14 +53,14 @@ describe('MultiSigScriptHashInput', function() {
       .to(address, 1000000);
     var input = transaction.inputs[0];
 
-    _.every(input.publicKeysWithoutSignature(), function(publicKeyMissing) {
+    input.publicKeysWithoutSignature().every(publicKeyMissing => {
       var serialized = publicKeyMissing.toString();
       return serialized === public1.toString() ||
               serialized === public2.toString() ||
               serialized === public3.toString();
     }).should.equal(true);
     transaction.sign(privateKey1);
-    _.every(input.publicKeysWithoutSignature(), function(publicKeyMissing) {
+    input.publicKeysWithoutSignature().every(publicKeyMissing => {
       var serialized = publicKeyMissing.toString();
       return serialized === public2.toString() ||
               serialized === public3.toString();

packages/bitcore-lib-doge/lib/block/block.js

@@ -22,7 +22,7 @@ function Block(arg) {
   if (!(this instanceof Block)) {
     return new Block(arg);
   }
-  _.extend(this, Block._from(arg));
+  Object.assign(this, Block._from(arg));
   return this;
 }
 

packages/bitcore-lib-doge/lib/block/merkleblock.js

@@ -60,7 +60,7 @@ function MerkleBlock(arg) {
   } else {
     throw new TypeError('Unrecognized argument for MerkleBlock');
   }
-  _.extend(this,info);
+  Object.assign(this, info);
   this._flagBitsUsed = 0;
   this._hashesUsed = 0;
   return this;

packages/bitcore-lib-doge/lib/encoding/base58.js

@@ -1,6 +1,5 @@
 'use strict';
 
-var _ = require('lodash');
 var bs58 = require('bs58');
 var buffer = require('buffer');
 
@@ -26,7 +25,7 @@ Base58.validCharacters = function validCharacters(chars) {
   if (buffer.Buffer.isBuffer(chars)) {
     chars = chars.toString();
   }
-  return _.every(_.map(chars, function(char) { return (ALPHABET.includes(char)) }));
+  return [...chars].every(c => ALPHABET.includes(c));
 };
 
 Base58.prototype.set = function(obj) {

packages/bitcore-lib-doge/lib/errors/index.js

@@ -30,7 +30,7 @@ var traverseNode = function(parent, errorDefinition) {
 
 /* jshint latedef: false */
 var childDefinitions = function(parent, childDefinitions) {
-  _.each(childDefinitions, function(childDefinition) {
+  childDefinitions.forEach((childDefinition) => {
     traverseNode(parent, childDefinition);
   });
 };

packages/bitcore-lib-doge/lib/hdprivatekey.js

@@ -75,7 +75,7 @@ function HDPrivateKey(arg) {
 HDPrivateKey.isValidPath = function(arg, hardened) {
   if (_.isString(arg)) {
     var indexes = HDPrivateKey._getDerivationIndexes(arg);
-    return indexes !== null && _.every(indexes, HDPrivateKey.isValidPath);
+    return indexes !== null && indexes.every(HDPrivateKey.isValidPath);
   }
 
   if (_.isNumber(arg)) {
@@ -100,11 +100,11 @@ HDPrivateKey._getDerivationIndexes = function(path) {
   var steps = path.split('/');
 
   // Special cases:
-  if (_.includes(HDPrivateKey.RootElementAlias, path)) {
+  if (HDPrivateKey.RootElementAlias.includes(path)) {
     return [];
   }
 
-  if (!_.includes(HDPrivateKey.RootElementAlias, steps[0])) {
+  if (!HDPrivateKey.RootElementAlias.includes(steps[0])) {
     return null;
   }
 

packages/bitcore-lib-doge/lib/hdpublickey.js

@@ -76,7 +76,7 @@ function HDPublicKey(arg) {
 HDPublicKey.isValidPath = function(arg) {
   if (_.isString(arg)) {
     var indexes = HDPrivateKey._getDerivationIndexes(arg);
-    return indexes !== null && _.every(indexes, HDPublicKey.isValidPath);
+    return indexes !== null && indexes.every(HDPublicKey.isValidPath);
   }
 
   if (_.isNumber(arg)) {

packages/bitcore-lib-doge/lib/opcode.js

@@ -224,7 +224,7 @@ for (var k in Opcode.map) {
 }
 
 // Easier access to opcodes
-_.extend(Opcode, Opcode.map);
+Object.assign(Opcode, Opcode.map);
 
 /**
  * @returns true if opcode is one of OP_0, OP_1, ..., OP_16

packages/bitcore-lib-doge/lib/transaction/transaction.js

@@ -1110,7 +1110,7 @@ Transaction.prototype._calculateWeight = function() {
 
 Transaction.prototype._removeOutput = function(index) {
   var output = this.outputs[index];
-  this.outputs = _.without(this.outputs, output);
+  this.outputs = this.outputs.filter(x => x !== output);
   this._outputAmount = undefined;
 };
 
@@ -1218,7 +1218,7 @@ Transaction.prototype.removeInput = function(txId, outputIndex) {
     throw new errors.Transaction.InvalidIndex(index, this.inputs.length);
   }
   var input = this.inputs[index];
-  this.inputs = _.without(this.inputs, input);
+  this.inputs = this.inputs.filter(x => x !== input);
   this._inputAmount = undefined;
   this._updateChangeOutput();
 };

packages/bitcore-lib-doge/lib/uri.js

@@ -1,6 +1,5 @@
 'use strict';
 
-var _ = require('lodash');
 var URL = require('url');
 
 var Address = require('./address');
@@ -179,7 +178,7 @@ URI.prototype.toObject = URI.prototype.toJSON = function toObject() {
       json[m] = this[m].toString();
     }
   }
-  _.extend(json, this.extras);
+  Object.assign(json, this.extras);
   return json;
 };
 
@@ -202,7 +201,7 @@ URI.prototype.toString = function() {
   if (this.r) {
     query.r = this.r;
   }
-  _.extend(query, this.extras);
+  Object.assign(query, this.extras);
 
   return URL.format({
     protocol: 'dogecoin:',