Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include hash in toObject/toJSON results. #1311

Merged
merged 4 commits into from
Aug 13, 2015
Merged

Include hash in toObject/toJSON results. #1311

merged 4 commits into from
Aug 13, 2015

Conversation

braydonf
Copy link
Contributor

@maraoz
Copy link
Contributor

maraoz commented Aug 11, 2015

I would add a check in fromObject to see if the calculated hash equals the received hash

@braydonf
Copy link
Contributor Author

Currently the hash property in fromObject is ignored, and the hash would then always be the computed value...

@braydonf
Copy link
Contributor Author

Updated! The argument hash properties are checked for consistency with the calculated hash for both Transaction and BlockHeader.

@maraoz
Copy link
Contributor

maraoz commented Aug 13, 2015

Nice. LGTM

pnagurny added a commit that referenced this pull request Aug 13, 2015
@pnagurny
Merge pull request #1311 from braydonf/tojsonhashes
79db9cc 
Include hash in toObject/toJSON results.
@pnagurny pnagurny merged commit 79db9cc into bitpay:master Aug 13, 2015
@braydonf braydonf mentioned this pull request Aug 25, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@braydonf @maraoz @pnagurny @marianorod