fix signature hasDefinedHashtype #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
I just updated to also check with JSUtil.isNaturalNumber. The reason is that I added another test case, nhashtype being set to the floating point 1.1, and that was passing. I figured it'd be better to have that case fail/return false because that might help library clients fail faster and narrow down a bug to an incorrectly set nhashtype. I also saw that #1266 mentions the main hasDefinedHashtype bug fixed by this PR. |
…ore function IsDefinedHashtypeSignature
braydonf
pushed a commit
that referenced
this pull request
Jul 1, 2015
fix signature hasDefinedHashtype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/crypto/signature.hasDefinedHashtype was not very closely matching Bitcoin Core's IsDefinedHashtypeSignature: https://github.com/bitcoin/bitcoin/blob/bc60b2b4b401f0adff5b8b9678903ff8feb5867b/src/script/interpreter.cpp#L180-189
This PR narrows that gap.
The purpose of the isNumber check is to protect against instances that simply have not had an nhashtype set (yet).
The previous version of this method was not considering Signature.SIGHASH_ANYONECANPAY at all. That was the obvious thing to fix.