Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/fee estimation #1271

Merged
merged 3 commits into from
Jun 11, 2015
Merged

Fix/fee estimation #1271

merged 3 commits into from
Jun 11, 2015

Conversation

isocolsky
Copy link
Contributor

This PR does two things:

  • Fix fee calculation used to determine if a change address is needed (when estimating tx size)
  • Allow configuration of fee per KB for each transaction.

@matiu
Copy link
Contributor

matiu commented Jun 11, 2015

LGTM. having the possibility to set fee per KB will be useful in many use cases.

@pnagurny
Copy link
Contributor

ACK

matiu added a commit that referenced this pull request Jun 11, 2015
@matiu
Merge pull request #1271 from isocolsky/fix/fee_estimation
a4ac3f5 
Fix/fee estimation
@matiu matiu merged commit a4ac3f5 into bitpay:master Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isocolsky @matiu @pnagurny