Handling Invalid Output Scripts. Closes #1230 #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braydonf
changed the title
braydonf
force-pushed
the
bug/output-to-script
branch
from
fa7f313 to
a23b364
Compare
braydonf
changed the title
| var output = new Output({ | ||
| satoshis: 1000, | ||
| script: 'bad' | ||
| }); | ||
| }).should.throw('Invalid hex string'); |
There was a problem hiding this comment.
Would it be better to throw a more specific error? (i.e: errors.Transaction.Output.InvalidScript)?
There was a problem hiding this comment.
This is an error from Buffer that will take the else path, so we can handle an InvalidScript but not other types of errors.
braydonf
changed the title
braydonf
force-pushed
the
bug/output-to-script
branch
4 times, most recently
from
9e19411 to
cb9996f
Compare
braydonf
changed the title
- Changed toObject serialization to always use a hexa string for a script - Updated inspect method to handle a null script - Roundtrip toObject/fromObject with an invalid script - Additional test coverage for Output
braydonf
force-pushed
the
bug/output-to-script
branch
from
cb9996f to
458abe0
Compare
|
Looks good to me |
pnagurny
added a commit
that referenced
this pull request
May 14, 2015
Handling Invalid Output Scripts. Closes #1230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toObjectserialization to always use a hexa string for a scripttoObjectwith an invalid script