-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added compilation support for Node.js v4 #348
Conversation
cd4271b
to
101250e
Compare
@@ -268,7 +292,7 @@ index cce687a..0f162ff 100644 | |||
{ | |||
SetupEnvironment(); | |||
@@ -175,3 +180,4 @@ int main(int argc, char* argv[]) | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a stray space here? I can't tell exactly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove it, there is a space there.
this worked ok on debian jesse, but on Mac 10.10, it get: module.js:339 Error: Cannot find module 'db/package.json' when running: node bin/start node 4.2.1 |
I don't think |
works using ./bin/bitcore start and removing insight related plugins from bitcore-node.json |
LGTM |
tested - works locally. LGTM |
Added compilation support for Node.js v4
Closes: bitpay/bitcore#1361
Closes: #259