Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support nullable parameters #33

Merged
merged 3 commits into from
Feb 23, 2022
Merged

Support nullable parameters #33

merged 3 commits into from
Feb 23, 2022

Conversation

miguelaeh
Copy link
Contributor

Signed-off-by: Miguel A. Cabrera Minagorri [email protected]

Description of the change

This PR adds support for nullable parameters through a new modifier

Benefits

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Version bumped in package.json and package-lock.json according to semver.
  • New features are documented in the README.md
  • New features contain a new test at the tests folder
  • All tests pass running npm test

@miguelaeh
Support nullable parameters
1cd14d3 
Signed-off-by: Miguel A. Cabrera Minagorri <[email protected]>
@miguelaeh
Support multiple modifiers for a single parameter
507b102 
Signed-off-by: Miguel A. Cabrera Minagorri <[email protected]>
antgamdia
antgamdia approved these changes Feb 22, 2022
View reviewed changes
Copy link

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh great! Thanks a lot for implementing this fix! I'll give it a try with the Kubeapps schema tomorrow

@miguelaeh
Nullable as the final modifier must preserve the default value, just …
f5b44dc 
…apply the rest of modifiers for the type

Signed-off-by: Miguel A. Cabrera Minagorri <[email protected]>
@miguelaeh miguelaeh merged commit 1af1288 into main Feb 23, 2022
@miguelaeh miguelaeh deleted the nullableOption branch February 23, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antgamdia antgamdia antgamdia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow values with null values during the schema generation
2 participants
@miguelaeh @antgamdia