-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/postgresql] Adapt to Helm v3 and change nomenclature #4385
Conversation
…res-terminology-change
…nami-charts into postgresqlMajor
bitnami/postgresql/README.md
Outdated
- https://helm.sh/docs/topics/v2_v3_migration/ | ||
- https://helm.sh/blog/migrate-from-helm-v2-to-helm-v3/ | ||
|
||
#### Breaking changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add here a paragraph about the breaking changes in this major, the ones related to the renaming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is explained above, deleting this empty section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I have just updated the bitnami images with the latest known immutable tags:
|
Description of the change
This PR adapts the bitnami/postgresql to the Helm v3 apiversion v2 and changes the nomclature for master and slave to primary and readReplica.
We are taking ownership of #4049
Benefits
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver.[bitnami/chart]
)values-production.yaml
apart fromvalues.yaml
, ensure that you implement the changes in both files