Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/postgresql] Adapt to Helm v3 and change nomenclature #4385

Merged
merged 8 commits into from
Nov 17, 2020

Conversation

miguelaeh
Copy link
Contributor

Description of the change
This PR adapts the bitnami/postgresql to the Helm v3 apiversion v2 and changes the nomclature for master and slave to primary and readReplica.

We are taking ownership of #4049

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/chart])
  • If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

⚠️ Keep in mind that if you want to make changes to the kubeapps chart, please implement them in the kubeapps repository. This is only a synchronized mirror.

- https://helm.sh/docs/topics/v2_v3_migration/
- https://helm.sh/blog/migrate-from-helm-v2-to-helm-v3/

#### Breaking changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add here a paragraph about the breaking changes in this major, the ones related to the renaming

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is explained above, deleting this empty section

Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miguelaeh miguelaeh merged commit 7eabc85 into bitnami:master Nov 17, 2020
@miguelaeh miguelaeh deleted the postgresqlMajor branch November 17, 2020 15:19
@miguelaeh miguelaeh restored the postgresqlMajor branch November 17, 2020 16:48
@miguelaeh miguelaeh deleted the postgresqlMajor branch November 17, 2020 16:49
@bitnami-bot
Copy link
Contributor

I have just updated the bitnami images with the latest known immutable tags:

  • "docker.io/bitnami/postgresql:11.10.0-debian-10-r5"
  • "docker.io/bitnami/postgres-exporter:0.8.0-debian-10-r275"
  • "docker.io/bitnami/minideb:buster"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants