Fix syntax (parameter order) for flaskServerSecretKey in template#33248
Merged
carrodher merged 3 commits intobitnami:mainfrom Apr 29, 2025
Merged
Fix syntax (parameter order) for flaskServerSecretKey in template#33248carrodher merged 3 commits intobitnami:mainfrom
carrodher merged 3 commits intobitnami:mainfrom
Conversation
Signed-off-by: Magnus Billvik <magnus@billvik.se>
Signed-off-by: Magnus Billvik <magnus@billvik.se>
Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
carrodher
added
verify
carrodher
approved these changes
Apr 29, 2025
rstribrn
pushed a commit
to rstribrn/bitnami_charts
that referenced
this pull request
May 9, 2025
…tnami#33248) * Fix syntax (parameter order) for flaskServerSecretKey in template Signed-off-by: Magnus Billvik <magnus@billvik.se> * Version bump Signed-off-by: Magnus Billvik <magnus@billvik.se> * Update CHANGELOG.md Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com> --------- Signed-off-by: Magnus Billvik <magnus@billvik.se> Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com> Co-authored-by: Bitnami Bot <bitnami.bot@broadcom.com>
QustodioPablo
pushed a commit
to QustodioPablo/charts
that referenced
this pull request
May 16, 2025
…tnami#33248) * Fix syntax (parameter order) for flaskServerSecretKey in template Signed-off-by: Magnus Billvik <magnus@billvik.se> * Version bump Signed-off-by: Magnus Billvik <magnus@billvik.se> * Update CHANGELOG.md Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com> --------- Signed-off-by: Magnus Billvik <magnus@billvik.se> Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com> Co-authored-by: Bitnami Bot <bitnami.bot@broadcom.com> Signed-off-by: Pablo Fernandez <pablo.fernandez@qustodio.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix syntax (parameter order) for flaskServerSecretKey in template
Description of the change
Fix in template for the
flaskServerSecretKeydefinition, that makes it first look for a configured value before falling back to the default (hard-coded) value.Benefits
The template definition for
flaskServerSecretKeyworks as expected, and doesn't always take the default value.Possible drawbacks
None (what I can see).
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm