Skip to content

[bitnami/redis] Switch shell from /bin/sh to /bin/bash to improve process handling#33181

Merged
juan131 merged 8 commits intobitnami:mainfrom
PauloFerreira25:redis-probe-bash
Apr 30, 2025
Merged

[bitnami/redis] Switch shell from /bin/sh to /bin/bash to improve process handling#33181
juan131 merged 8 commits intobitnami:mainfrom
PauloFerreira25:redis-probe-bash

Conversation

@PauloFerreira25
Copy link
Contributor

@PauloFerreira25 PauloFerreira25 commented Apr 25, 2025

Description of the change

This change replaces the default shell from /bin/sh to /bin/bash in scripts executed by the container.

Benefits

Using /bin/bash allows for more reliable process management and advanced signal handling. This change is aimed at mitigating issues related to defunct (zombie) processes observed in certain server environments.

Applicable issues

fixes:
- #9654
- #8475
- #5328
- #2441

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added the triage Triage is needed label Apr 25, 2025
@github-actions github-actions bot requested a review from carrodher April 25, 2025 13:58
Signed-off-by: Paulo Ferreira <pauloaugustodealmeidaferreira@gmail.com>
Signed-off-by: Paulo Ferreira <pauloaugustodealmeidaferreira@gmail.com>
@PauloFerreira25
Copy link
Contributor Author

image

Although the previous support cases were marked as resolved, the issue is still occurring. I chose not to open a new ticket and instead submitted this PR as a potential fix.

@carrodher
Copy link
Member

Thanks for your contribution! For our automated testing pipeline to evaluate these modifications, it is necessary to separate the changes into two different PRs, one for each chart. Could you please do that before continuing? Thanks.

@PauloFerreira25 PauloFerreira25 changed the title [bitnami/redis-cluster][bitnami/redis] Switch shell from /bin/sh to /bin/bash to improve process handling [bitnami/redis] Switch shell from /bin/sh to /bin/bash to improve process handling Apr 29, 2025
…n PR

Signed-off-by: Paulo Ferreira <pauloaugustodealmeidaferreira@gmail.com>
@PauloFerreira25
Copy link
Contributor Author

Yes, absolutely! I’ll split the changes into two separate PRs as requested.

Signed-off-by: Paulo Ferreira <pauloaugustodealmeidaferreira@gmail.com>
@PauloFerreira25
Copy link
Contributor Author

#33250

Signed-off-by: Paulo Ferreira <pauloaugustodealmeidaferreira@gmail.com>
Signed-off-by: Paulo Ferreira <pauloaugustodealmeidaferreira@gmail.com>
Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress redis labels Apr 29, 2025
@github-actions github-actions bot removed the triage Triage is needed label Apr 29, 2025
@github-actions github-actions bot removed the request for review from carrodher April 29, 2025 17:11
@github-actions github-actions bot requested a review from juan131 April 29, 2025 17:11
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! LGTM

@juan131 juan131 merged commit cfe2165 into bitnami:main Apr 30, 2025
31 checks passed
rstribrn pushed a commit to rstribrn/bitnami_charts that referenced this pull request May 9, 2025
QustodioPablo pushed a commit to QustodioPablo/charts that referenced this pull request May 16, 2025
…cess handling (bitnami#33181)

Signed-off-by: Pablo Fernandez <pablo.fernandez@qustodio.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

redis solved verify Execute verification workflow for these changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants