[bitnami/common] add namespaces to extraPodAffinityTerms for affinities#33173
Merged
juan131 merged 8 commits intobitnami:mainfrom Apr 30, 2025
Merged
[bitnami/common] add namespaces to extraPodAffinityTerms for affinities#33173juan131 merged 8 commits intobitnami:mainfrom
juan131 merged 8 commits intobitnami:mainfrom
Conversation
Signed-off-by: klamas1 <klamas1@gmail.com>
Signed-off-by: klamas1 <klamas1@gmail.com>
…example Signed-off-by: klamas1 <klamas1@gmail.com>
…example Signed-off-by: klamas1 <klamas1@gmail.com>
Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
juan131
requested changes
Apr 28, 2025
juan131
requested changes
Apr 30, 2025
Contributor
juan131
left a comment
There was a problem hiding this comment.
The changes LGTM, but please ensure you merge the latest changes in the origin's main branch in your fork's branch and then, update the PR. Thanks in advance.
Signed-off-by: Rakhimov Marat <klamas1@gmail.com>
Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
jpinxten
pushed a commit
to jpinxten/bitnami-charts
that referenced
this pull request
May 5, 2025
…es (bitnami#33173) Signed-off-by: jpinxten <jeroen.pinxten@icometrix.com>
rstribrn
pushed a commit
to rstribrn/bitnami_charts
that referenced
this pull request
May 9, 2025
QustodioPablo
pushed a commit
to QustodioPablo/charts
that referenced
this pull request
May 16, 2025
…es (bitnami#33173) Signed-off-by: Pablo Fernandez <pablo.fernandez@qustodio.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix indentation and namespace handling in affinity helpers
Changes
Fixed indentation in
common.affinities.pods.hard:namespacesis now at the same level aslabelSelectorcommon.tplvalues.renderfromnindent 10tonindent 8Unified namespace handling in both helpers (
softandhard):{{ .context.Release.Namespace }}{{ $.context.Release.Namespace }}because in rangecommon.tplvalues.renderPreserved dashes before
includeto prevent line breaks when usingnindentExample of correct YAML structure
Testing
Changes were tested on Helm chart rendering with various namespace configurations.
Benefits
Possible drawbacks
Not found
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm