-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/redis] feat: Add external access service for redis sentinel #32190
Conversation
I'll fix the signed missing |
Signed-off-by: Benjamin Leveque <[email protected]>
Signed-off-by: Benjamin Leveque <[email protected]>
Signed-off-by: Benjamin Leveque <[email protected]>
Signed-off-by: Benjamin Leveque <[email protected]>
Signed-off-by: Benjamin Leveque <[email protected]>
Signed-off-by: Benjamin Leveque <[email protected]>
Signed-off-by: Benjamin Leveque <[email protected]>
Signed-off-by: Benjamin Leveque <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Benjamin Leveque <[email protected]>
Signed-off-by: unkls ben <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Hello, |
…tinel.commonLabels Signed-off-by: Benjamin Leveque <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Benjamin Leveque <[email protected]>
Signed-off-by: Benjamin Leveque <[email protected]>
Signed-off-by: Benjamin Leveque <[email protected]>
Signed-off-by: David Gomez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for this great contribution!
Signed-off-by: Bitnami Containers <[email protected]>
Thanks @dgomezleon for the review ! Could you review it once again ? As I understand the changelog.md was updated by another PR merging |
Description of the change
Benefits
New feature for redis chart, that will allow externalAccess using Loadbalancer IP. Same as redis-cluster chart.
Possible drawbacks
None as the change is backward compatible, and previous users can continue using the chart without any issues.
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm