Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/redis] feat: Add external access service for redis sentinel #32190

Merged
merged 18 commits into from
Mar 3, 2025

Conversation

unkls
Copy link
Contributor

@unkls unkls commented Feb 27, 2025

Description of the change

  • Implement external Access for redis-sentinel using Loadbalancer service
  • Add new values for managing new external service
  • Update script start sentinel and start node to use external IP
  • Update configmap sentinel and

Benefits

New feature for redis chart, that will allow externalAccess using Loadbalancer IP. Same as redis-cluster chart.

Possible drawbacks

None as the change is backward compatible, and previous users can continue using the chart without any issues.

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added redis triage Triage is needed labels Feb 27, 2025
@github-actions github-actions bot requested a review from carrodher February 27, 2025 09:22
@unkls
Copy link
Contributor Author

unkls commented Feb 27, 2025

I'll fix the signed missing
Signed-off-by: Benjamin Leveque [email protected]

bitnami-bot and others added 4 commits February 27, 2025 09:39
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
@clement0210
Copy link

Hello,
Same needs in my side to be able to use Sentinel behind a Ingress controller on cilium CNI. Really appreciated this contribution 🙏

@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Feb 27, 2025
@github-actions github-actions bot removed the triage Triage is needed label Feb 27, 2025
@github-actions github-actions bot removed the request for review from carrodher February 27, 2025 20:01
@github-actions github-actions bot requested a review from dgomezleon February 27, 2025 20:01
bitnami-bot and others added 2 commits February 28, 2025 17:02
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Benjamin Leveque <[email protected]>
Signed-off-by: Benjamin Leveque <[email protected]>
dgomezleon
dgomezleon previously approved these changes Mar 3, 2025
Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this great contribution!

@dgomezleon dgomezleon enabled auto-merge (squash) March 3, 2025 11:46
Signed-off-by: Bitnami Containers <[email protected]>
@unkls
Copy link
Contributor Author

unkls commented Mar 3, 2025

Thanks @dgomezleon for the review ! Could you review it once again ? As I understand the changelog.md was updated by another PR merging

@dgomezleon dgomezleon merged commit 0582ac3 into bitnami:main Mar 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redis solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants