[bitnami/mongodb] feat: allow setting targetLabel and podTargetLabels array on ServiceMonitor
#30531
+28
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrodher
added
verify
migruiz4
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Thank you for your contribution @umarhussain15!
Changes look good to me, but I can not accept this PR until the changes to the values.schema.json have been reverted.
We have had issues in the past where having an schema that fully covers the values.yaml is 'too strict' and ends up causing severe issues with many values, especially those that are rendered as template or allow different value types (string/array/object).
…els` array on ServiceMonitor This will allow chart users to include additional labels to prometheus metrics collected on mongodb Signed-off-by: Umar Hussain <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This update to MongoDB chart will allow users to set targetLabels and podTargetLabels arrays on ServiceMonitor resource in the chart. By default, the arrays are set empty and there is a check in the ServiceMonitor file to only put these array if they are set and array is not empty.
Spec ref: https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api.md#servicemonitorspec
Benefits
Allows users to further enrich Prometheus metrics with new labels when they are scraped by the server.
Possible drawbacks
None
Applicable issues
None
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm