[bitnami/minio] fix secret creation check #30135
Open
+10
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The "Option to use a secret" introduced in
14.7.0
also brought a small bug with it: The check if the secret should be created expects a boolean, but "include" always returns a string . Because it is not used directly (only in the minio.createSecret template), even settingauth.useSecret
tofalse
will result in the string "false". This string is then interpreted as / casted to a boolean in the correspondingif
-clause, where it always is translated totrue
because it is not empty. (If you setauth.useSecret
to an empty string, the secret will not be created)Benefits
auth.useSecret
actually works as expected:true
the secret will be created (ifexistingSecret
is empty)false
the secret won't be createdPossible drawbacks
I don't see any (yet)
Applicable issues
Additional information
There would also be the option to change all
if (include "minio.createSecret" .)
s so that they check the string's content instead of only for emptiness. But this would create a larger diff, so I chose not to do it that way.Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.