Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/minio] fix secret creation check #30135

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

c4tz
Copy link
Contributor

@c4tz c4tz commented Oct 30, 2024

Description of the change

The "Option to use a secret" introduced in 14.7.0 also brought a small bug with it: The check if the secret should be created expects a boolean, but "include" always returns a string . Because it is not used directly (only in the minio.createSecret template), even setting auth.useSecret to false will result in the string "false". This string is then interpreted as / casted to a boolean in the corresponding if-clause, where it always is translated to true because it is not empty. (If you set auth.useSecret to an empty string, the secret will not be created)

Benefits

auth.useSecret actually works as expected:

  • If set to true the secret will be created (if existingSecret is empty)
  • If set to false the secret won't be created

Possible drawbacks

I don't see any (yet)

Applicable issues

Additional information

There would also be the option to change all if (include "minio.createSecret" .)s so that they check the string's content instead of only for emptiness. But this would create a larger diff, so I chose not to do it that way.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Bitnami Containers <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Oct 30, 2024
@github-actions github-actions bot removed the triage Triage is needed label Oct 30, 2024
@github-actions github-actions bot removed the request for review from javsalgar October 30, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress minio verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants