Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/*] Remove wrong comment about imagePullPolicy #30107

Merged
merged 1 commit into from
Oct 28, 2024
Merged

[bitnami/*] Remove wrong comment about imagePullPolicy #30107

merged 1 commit into from
Oct 28, 2024

Conversation

dgomezleon
Copy link
Member

Description of the change

This PR removes a comment that wrongly suggests that imagePullPolicy is automatically changed to Always when using latest tag.

Benefits

Avoid confusion regarding imagePullPolicy behavior.

Possible drawbacks

N/A

Applicable issues

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added verify Execute verification workflow for these changes bitnami labels Oct 28, 2024
@github-actions github-actions bot requested a review from juan131 October 28, 2024 12:58
juan131
juan131 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgomezleon dgomezleon merged commit a51f9e4 into main Oct 28, 2024
14 of 15 checks passed
@dgomezleon dgomezleon deleted the Remove-pullPolicy-comment branch October 28, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan131 juan131 juan131 approved these changes

@fmulero fmulero fmulero approved these changes

Assignees

@juan131 juan131

Labels
bitnami solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/mlflow] imagePullPolicy of mlflow container is not set according to docstring
3 participants
@dgomezleon @juan131 @fmulero