Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/postgresql-ha] fix POSTGRES_POSTGRES_PASSWORD env var when generating secrets #30106

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

davidfrickert
Copy link

@davidfrickert davidfrickert commented Oct 28, 2024

Description of the change

When using a username that is not "postgres" and no credentials or existingSecret is passed via values, POSTGRES_POSTGRES_PASSWORD env var needs to be passed to postgres pod.
This PR fixes a condition that should not have been negated, so that when username is not "postgres" and credentials are generated, we pass the env var to the pod.

Applicable issues

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

- should pass if password provided or if generated

Signed-off-by: David Frickert <[email protected]>
@github-actions github-actions bot added postgresql-ha triage Triage is needed labels Oct 28, 2024
@davidfrickert davidfrickert changed the title fix POSTGRES_POSTGRES_PASSWORD env var when generating secrets [charts/postgresql-ha] fix POSTGRES_POSTGRES_PASSWORD env var when generating secrets Oct 28, 2024
@davidfrickert davidfrickert changed the title [charts/postgresql-ha] fix POSTGRES_POSTGRES_PASSWORD env var when generating secrets [bitnami/postgresql-ha] fix POSTGRES_POSTGRES_PASSWORD env var when generating secrets Oct 28, 2024
@javsalgar
Copy link
Contributor

Hi!

Thank you so much for the PR! Could you bump the chart patch version?

@davidfrickert
Copy link
Author

Hi!

Thank you so much for the PR! Could you bump the chart patch version?

Hi, no worries!
Done

bitnami-bot and others added 2 commits October 29, 2024 09:48
Signed-off-by: Bitnami Containers <[email protected]>
@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Oct 30, 2024
@github-actions github-actions bot removed the triage Triage is needed label Oct 30, 2024
@github-actions github-actions bot removed the request for review from javsalgar October 30, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress postgresql-ha verify Execute verification workflow for these changes
Projects
None yet
4 participants