Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/postgresql-ha] Fix pgpool default readinessProbe #30028

Merged
merged 6 commits into from
Oct 23, 2024
Merged

[bitnami/postgresql-ha] Fix pgpool default readinessProbe #30028

merged 6 commits into from
Oct 23, 2024

Conversation

yukha-dw
Copy link
Contributor

@yukha-dw yukha-dw commented Oct 22, 2024 •
edited
Loading

Description of the change

Import password from PGPOOL_POSTGRES_PASSWORD_FILE when postgresql.usePasswordFile set to true on Pgpool default readinessProbe.

Benefits

Fix Pgpool default readinessProbe when user set postgresql.usePasswordFile=true

Possible drawbacks

None

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added postgresql-ha triage Triage is needed labels Oct 22, 2024
@yukha-dw yukha-dw marked this pull request as ready for review October 22, 2024 04:10
@bitnami-bot
Update CHANGELOG.md
df9b520 
Signed-off-by: Bitnami Containers <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Oct 22, 2024
@github-actions github-actions bot removed the triage Triage is needed label Oct 22, 2024
@github-actions github-actions bot removed the request for review from carrodher October 22, 2024 08:21
migruiz4 and others added 3 commits October 23, 2024 10:58
@migruiz4
Merge branch 'main' into main
6487ec1 
Signed-off-by: Miguel Ruiz <[email protected]>
@migruiz4
Bump chart version
513cc71 
Signed-off-by: Miguel Ruiz <[email protected]>

Signed-off-by: Miguel Ruiz <[email protected]>
@bitnami-bot
Update CHANGELOG.md
bb73988 
Signed-off-by: Bitnami Containers <[email protected]>
migruiz4
migruiz4 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@migruiz4 migruiz4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @yukha-dw, looks good to me!

@migruiz4 migruiz4 merged commit 49ad0af into bitnami:main Oct 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migruiz4 migruiz4 migruiz4 approved these changes

Assignees

@migruiz4 migruiz4

Labels
postgresql-ha solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/postgresql-ha] pgpool's readinessProbe doesn't working when using PGPOOL_POSTGRES_PASSWORD_FILE
4 participants
@yukha-dw @migruiz4 @carrodher @bitnami-bot