Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/postgresql-ha] Cloning huge data from primary node fails due to livenessProbe #29948

Merged
merged 7 commits into from
Oct 29, 2024

Conversation

percenuage
Copy link
Contributor

@percenuage percenuage commented Oct 16, 2024

Description of the change

Update livenessProbe in order to check if process are in "data standby clone" step. If the synchronization from primary are longer than the livenessProbe fails, the replicas will restart in loop. It works for small data since it's fast but not with more than 20Go (I have 300 Go on primary on SSD and it has taken around 25 min to sync).

Maybe there is a special command from PG to check but I haven't found any.

Personal thanks to @exename (#4894 (comment))

Benefits

Allows flexibility to add replicas during the run with existing data.

Applicable issues

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@carrodher
Copy link
Member

Thank you for initiating this pull request. We appreciate your effort. This is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

Signed-off-by: Bitnami Containers <[email protected]>
@percenuage
Copy link
Contributor Author

@carrodher Hi, I re-submit with signed commit :) Is is ok ?

@carrodher
Copy link
Member

Here you can see some tips about how you can sign the previous commits

Signed-off-by: Bitnami Containers <[email protected]>
@percenuage
Copy link
Contributor Author

@carrodher "All checks have passed" :) I don't know when you will merge but since the time flies, there is conflict appears on CHANGELOG and chart.yaml.

Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Oct 24, 2024
@github-actions github-actions bot removed the triage Triage is needed label Oct 24, 2024
@github-actions github-actions bot removed the request for review from carrodher October 24, 2024 10:13
@github-actions github-actions bot requested a review from juan131 October 24, 2024 10:13
Signed-off-by: Bitnami Containers <[email protected]>
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, this step involving syncing data on standby nodes should be done in a init-container so it doesn't affect probes.

@juan131 juan131 merged commit 16bd148 into bitnami:main Oct 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postgresql-ha solved verify Execute verification workflow for these changes
Projects
None yet
4 participants