Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/chainloop] Remove wrong entries from image verification #29913

Merged
merged 7 commits into from
Oct 18, 2024

Conversation

migruiz4
Copy link
Member

Description of the change

Removes wrong entries from the common.warnings.modifiedImages helper list.

Benefits

Fixes issues with image checking.

Possible drawbacks

None known.

Applicable issues

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added chainloop verify Execute verification workflow for these changes bitnami labels Oct 16, 2024
Signed-off-by: Bitnami Containers <[email protected]>
carrodher
carrodher previously approved these changes Oct 16, 2024
dgomezleon
dgomezleon previously approved these changes Oct 16, 2024
@migruiz4 migruiz4 dismissed stale reviews from dgomezleon and carrodher via 4f07392 October 18, 2024 06:52
Signed-off-by: Bitnami Containers <[email protected]>
carrodher
carrodher previously approved these changes Oct 18, 2024
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
@carrodher carrodher enabled auto-merge (squash) October 18, 2024 15:44
Signed-off-by: Bitnami Containers <[email protected]>
@carrodher carrodher merged commit 080bd03 into main Oct 18, 2024
10 checks passed
@carrodher carrodher deleted the images-helper-chainloop branch October 18, 2024 16:14
mike12806 pushed a commit to mike12806/charts that referenced this pull request Oct 30, 2024
…nami#29913)

* [bitnami/chainloop] Remove wrong entries from image verification

Signed-off-by: Miguel Ruiz <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

* Update Chart.yaml

Signed-off-by: Carlos Rodríguez Hernández <[email protected]>

---------

Signed-off-by: Miguel Ruiz <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
Co-authored-by: Bitnami Containers <[email protected]>
Co-authored-by: Carlos Rodríguez Hernández <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami chainloop solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants