[bitnami/mongodb-sharded] Changed to use namespaceOverride value when defining primaryhost in configsvr#29145
Merged
andresbono merged 2 commits intoSep 11, 2024
Conversation
Signed-off-by: Cho Hyunwoo <hyun0404woo@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
carrodher
added
verify
andresbono
approved these changes
Sep 11, 2024
andresbono
left a comment
andresbono
left a comment
Contributor
There was a problem hiding this comment.
Thank you for proposing this improvement! LGTM
bartramakers
pushed a commit
to bartramakers/bitnami-charts
that referenced
this pull request
Sep 18, 2024
… defining primaryhost in configsvr (bitnami#29145) * Change the configsvr namespace to use namespaceOverride value Signed-off-by: Cho Hyunwoo <hyun0404woo@gmail.com> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> --------- Signed-off-by: Cho Hyunwoo <hyun0404woo@gmail.com> Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
The namespace part of primaryhost in configsvr is modified to use
common.names.namespace.Benefits
When installing helm, we can set a consistent namespace by simply setting the override namespace without passing a separate namespace argument. Therefore, mongodb-sharded charts become easier to use as subcharts.
Possible drawbacks
N/A
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm