Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/redis] Fix zombie processes in readiness/liveness check #2453

Merged
merged 2 commits into from
May 1, 2020

Conversation

javsalgar
Copy link
Contributor

Description of the change

Change the signal of the liveness and readiness check. Also needed to perform several linting changes so our automated scripts would allow pushing the change.

Benefits

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/chart])
  • If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

⚠️ Keep in mind that if you want to make changes to the kubeapps chart, please implement them in the kubeapps repository. This is only a synchronized mirror.

@javsalgar javsalgar self-assigned this Apr 28, 2020
Copy link
Contributor

@miguelaeh miguelaeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@bitnami-bot
Copy link
Contributor

I have just updated the bitnami images with the latest known immutable tags:

  • "docker.io/bitnami/redis:5.0.9-debian-10-r4"
  • "docker.io/bitnami/redis-exporter:1.5.3-debian-10-r21"
  • "docker.io/bitnami/redis-sentinel:5.0.9-debian-10-r2"
  • "docker.io/bitnami/minideb:buster"
  • "docker.io/bitnami/minideb:buster"

@carrodher
Copy link
Member

Changes already in the repo:

▶ helm search repo bitnami/redis
NAME                 	CHART VERSION	APP VERSION	DESCRIPTION
bitnami/redis        	10.6.12      	5.0.9      	Open source, advanced key-value store. It is of...

Merging it...

@carrodher carrodher merged commit b9414f4 into master May 1, 2020
@carrodher carrodher deleted the fixrediszombie branch May 1, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zombie processes caused by health checks
4 participants