[bitnami/kafka] Make Kafka DefaultMode YAML 1.2 Compliant #21086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schrieveslaach
changed the title
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
With the YAML 1.2 spec octals must be prefixed with `0o` and not `0`. Parsers implementing the latest spec run into issues. See discussion here: dtolnay/serde-yaml#225 This commit makes the Kafka script mounts compliant with YAML 1.2. Signed-off-by: Marc Schreiber <[email protected]>
schrieveslaach
force-pushed
the
kafka-default-mode
branch
from
72792d7 to
c22eadf
Compare
|
@aoterolorenzo, any opinions on this PR? |
4 tasks
aoterolorenzo
approved these changes
Dec 11, 2023
|
Nice, thanks for merging! |
grouvie
pushed a commit
to grouvie/charts
that referenced
this pull request
Jan 25, 2024
With the YAML 1.2 spec octals must be prefixed with `0o` and not `0`. Parsers implementing the latest spec run into issues. See discussion here: dtolnay/serde-yaml#225 This commit makes the Kafka script mounts compliant with YAML 1.2. Signed-off-by: Marc Schreiber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
With the YAML 1.2 spec octals must be prefixed with
0oand not0. Parsers implementing the latest spec run into issues.Benefits
This commit makes the Kafka script mounts compliant with YAML 1.2.
Possible drawbacks
Applicable issues
None at the moment.
Additional information
See background discussion here: dtolnay/serde-yaml#225
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm